1975161 - [wdspec] Cookie tests for WebDriver classic can leave set cookies behind causing failures in later tests

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When doing the review for https://phabricator.services.mozilla.com/D255275 I noticed that the cookie tests like in add_cookie/add.py do not clean-up the set cookie at the end. The only reason why it currently works and doesn't cause side-effects is that for this test file the last tests at the end of the file are invalid scenarios which clean-up the cookie before and then checking that a cookie cannot be set.

So any situation like the following ones can break tests as run later on:

• If the invalid tests are failing early and the cookies are not deleted
• If a new test gets added at the end of the file

We should clean-up all the cookies at the end.

Comment 1

[Khalid AlHaddad]

Attachment: Bug 1975161 - Add autouse fixture to clear cookies before each test in files that add cookies via the WebDriver classic API. Remove clear_all_cookies helper, r?#webdriver-reviewers

Comment 2

[Khalid AlHaddad]

Hi, I cleared the cookies before and after each test, is that fine? Or did you want me to clear the cookies only in the end of the test file?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b997348cce2c
https://hg.mozilla.org/integration/autoland/rev/c29738378183
Add autouse fixture to clear cookies before each test in files that add cookies via the WebDriver classic API. Remove clear_all_cookies helper, r=webdriver-reviewers,whimboo

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c29738378183

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Khalid, thanks again for your contribution! If you have interest to do more please let us know or try to find another bug yourself. You can contact us here or via the #webdriver Matrix channel.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55205 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot