Closed
Bug 1975172
Opened 2 months ago
Closed 2 months ago
Remove unused `isRecoverable` property on `WebExtensionInstallException`
Categories
(Firefox for Android :: WebExtensions, task, P1)
Tracking
()
RESOLVED
FIXED
142 Branch
| Tracking | Status | |
|---|---|---|
| firefox142 | --- | fixed |
People
(Reporter: willdurand, Assigned: willdurand)
References
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
The WebExtensionInstallException class has a isRecoverable property that is not used currently: https://searchfox.org/mozilla-central/rev/311230215f69ac675d0fb4d5c0f5108228f17388/mobile/android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/webextension/WebExtension.kt#664. All the sub-classed exceptions currently are marked as recoverable even though it is incorrect.
It's also a problem because it can be confused with WebExtensionException.isRecoverable, which is used. This one, at least, seems to set the isRecoverable value correctly.
We should remove this property before we mistakenly start to use it.
|
Assignee | |
Comment 1•2 months ago
|
||
|
||
Updated•2 months ago
|
Assignee: nobody → wdurand
Status: NEW → ASSIGNED
|
||
Updated•2 months ago
|
Pushed by wdurand@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1dd195ccc750
https://hg.mozilla.org/integration/autoland/rev/1a23788b2280
Remove unused `isRecoverable` property on `WebExtensionInstallException`. r=twhite
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•