1975174 - DOMMatrix: rotateAxisAngleSelf(0, 0, z, alpha) should result in 2D matrix

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dan Burzo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

Evaluate: new DOMMatrix().rotateAxisAngleSelf(0,0,3,30).is2D

Actual results:

The resulting matrix should be 2D.

Expected results:

is2D = false

Comment 1

[Dan Burzo]

Oops, I mixed up the expected and actual fields. What I meant is that according to spec, rotateAxisAngleSelf() produces a 2D matrix (is2D = true) when both x and y are zero. Currently, Firefox 140/macOS returns is2D = false.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Kagami, looks like you worked on DOMMatrix.cpp, could you check this bug report? Thanks!

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1975174 - Fix rotateAxisAngleSelf not to always call Ensure3DMatrix r=smaug

I wonder it's worth keeping the current implementation deviation that we don't have is2D check but instead have mMatrix2D/3D. Seems that only complicates the implementation without a clear win.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ab5c6816386
https://hg.mozilla.org/integration/autoland/rev/4db51bdc85b9
Fix rotateAxisAngleSelf not to always call Ensure3DMatrix r=smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53602 for changes under testing/web-platform/tests

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9bb13a701cae
https://hg.mozilla.org/integration/autoland/rev/70caba360c04
Revert "Bug 1975174 - Fix rotateAxisAngleSelf not to always call Ensure3DMatrix r=smaug" for causing mochitest failures @ test_WebKitCSSMatrix.html

Comment 7

[amarc]

Backed out for causing mochitest failures @ test_WebKitCSSMatrix.html

• Backout link
• Push with failures
• Failure Log

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f9d441abc79c
https://hg.mozilla.org/integration/autoland/rev/6e7abc0bd6cf
Fix rotateAxisAngleSelf not to always call Ensure3DMatrix r=smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53624 for changes under testing/web-platform/tests

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6e7abc0bd6cf

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot