Status

()

Core
ImageLib
RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

30.68 KB, patch
Stuart Parmenter
: review+
blizzard
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
PPM was a handy simple image format for testing when libpr0n was being
written, but has now outlived its time in the mozilla tree.  Removal
gains us about 5K on linux.
(Assignee)

Comment 1

15 years ago
Created attachment 117314 [details] [diff] [review]
ppm removal
Doesn't biesi's work to make decoders completely pluggable largely obviate these
changes (except the build system ones?).
no... they are not yet completely pluggable... most importantly, the image
mimetype sniffing (in imgLoader.cpp) is not pluggable yet...

Comment 4

15 years ago
Well, it doesn't actually work anyway although mozilla recognizes the 
mime type so it's probably not a loss. However, it _is_ a common unix 
format do platform parity rather demands that you also remove bmp 
support as well.

Note that on Linux plugins are rather wedged with respect to large 
objects so it may not be possible to view such an image even with a 
plugin.
PPM works for me at http://gemal.dk/browserspy/images.html. Directly loading
http://gemal.dk/browserspy/pics/test.ppm also works for me.

Comment 6

15 years ago
Yes, but mozilla doesn't understand the generic anymap (.pnm) form. Apache does
so it sends image/x-portable-anymap which confuses mozilla. Because I often use
my own server to view the file system I see this a lot.
Comment on attachment 117314 [details] [diff] [review]
ppm removal

r=cls on the build changes

Comment 8

15 years ago
Comment on attachment 117314 [details] [diff] [review]
ppm removal

r=pavlov
Attachment #117314 - Flags: review+
(Assignee)

Updated

14 years ago
Attachment #117314 - Flags: superreview?(blizzard)
Comment on attachment 117314 [details] [diff] [review]
ppm removal

rs=blizzard
Attachment #117314 - Flags: superreview?(blizzard) → superreview+

Comment 10

14 years ago
Using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla
Firebird/0.6

when viewing:

http://www.unm.edu/~jmob/images/io.ppm

Colors are switched (i.e. it looks like the red and blue values are switched).
(Assignee)

Comment 11

14 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.