1975300 - nsIFOG's applyServerKnobsConfig's doctring references nonexistant API `set_metrics_enabled_config`

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P4)

Description

[Chris H-C :chutten|RustWeek (Back May 25)]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Firefox Contributors' Quick Reference,
     which has answers to most development questions.
3. Start working on this bug. Your job is to change this line that references set_metrics_enabled_config to instead reference apply_server_knobs_config.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #telemetry channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Richard LoRicco]

Hi Chris, I’m a new contributor, and I’d love to work on this. I'll be submitting a patch for this bug soon.

Comment 2

[Richard LoRicco]

Attachment: Bug 1975300 - Change nsIFOG applyServerKnobsConfig docstring to reference apply_server_knobs_config instead of set_metrics_enabled_config. r?chutten!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af9a4259302b
https://hg.mozilla.org/integration/autoland/rev/034e51651a5c
Change nsIFOG applyServerKnobsConfig docstring to reference apply_server_knobs_config instead of set_metrics_enabled_config. r=chutten DONTBUILD

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/034e51651a5c