1975419 - Use compiler intrinsic when available for saturated arithmetic

Status: RESOLVED FIXED

(Core :: MFBT, task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1975419 - Use compiler intrinsic for saturated arithmetic r=emilio!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c414351fca73
https://hg.mozilla.org/integration/autoland/rev/bf69c20b34e1
Use compiler intrinsic for saturated arithmetic r=emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d14ac4bc8a1f
https://hg.mozilla.org/integration/autoland/rev/7e250ada8ca2
Revert "Bug 1975419 - Use compiler intrinsic for saturated arithmetic r=emilio" for causing SM bustages on Saturate.h

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing SM bustages on Saturate.h

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e13374f3abb
https://hg.mozilla.org/integration/autoland/rev/8bdfd4f4966d
Use compiler intrinsic for saturated arithmetic r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2807d8fed64
https://hg.mozilla.org/integration/autoland/rev/7899cad53cdc
Revert "Bug 1975419 - Use compiler intrinsic for saturated arithmetic r=emilio" for causing SM bustages in Saturate.h

Comment 7

[Cristian Tuns]

Backed out for causing SM bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/sm-package/mozjs-142.0a1.0/obj-spider/dist/include/mozilla/Saturate.h:58:44: error: missing binary operator before token "("

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5f6ed09a9660
https://hg.mozilla.org/integration/autoland/rev/36b5faa59151
Use compiler intrinsic for saturated arithmetic r=emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6d2791eff18
https://hg.mozilla.org/integration/autoland/rev/d10d30c72215
Revert "Bug 1975419 - Use compiler intrinsic for saturated arithmetic r=emilio" for causing cppunittest failures

Comment 10

[Cristian Tuns]

Backed out for causing cppunittest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: ++satValue == (std::numeric_limits<T>::max()) (Test '++satValue == (std::numeric_limits<T>::max())' failed.), at /builds/worker/checkouts/gecko/mfbt/tests/TestSaturate.cpp:133

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1eb662c834be
https://hg.mozilla.org/integration/autoland/rev/4317c802d090
Use compiler intrinsic for saturated arithmetic r=emilio

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4317c802d090