1975439 - MacroAssembler-riscv64: MOZ_CRASH(needs to be implemented on this platform) in sub32FromMemAndBranchIfNegativeWithPatch

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Rong Bao [:csmantle]]

Attachment: Two of many failed tests due to this issue

For riscv64, MacroAssembler::sub32FromMemAndBranchIfNegativeWithPatch(Address, Label *) and MacroAssembler::patchSub32FromMemAndBranchIfNegative(CodeOffset, Imm32) are not implemented, leading to various failures when running jit-tests on both simulator and real hardware.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Bug 1975439 - [riscv64] Part 1: Implement MacroAssembler::sub32FromMemAndBranchIfNegativeWithPatch for riscv64. r=jandem

Comment 2

[Rong Bao [:csmantle]]

Attachment: Bug 1975439 - [riscv64] Part 2: Implement MacroAssembler::patchSub32FromMemAndBranchIfNegative for riscv64. r=jandem

Comment 3

[Rong Bao [:csmantle]]

This also affects native riscv64 builds, so marking this bug as blocking bug 1933206.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c8216afbf2dc
https://hg.mozilla.org/integration/autoland/rev/65687cb06be0
[riscv64] Part 1: Implement MacroAssembler::sub32FromMemAndBranchIfNegativeWithPatch for riscv64. r=jandem
https://github.com/mozilla-firefox/firefox/commit/cfb5ce48d176
https://hg.mozilla.org/integration/autoland/rev/35e0c5b79ded
[riscv64] Part 2: Implement MacroAssembler::patchSub32FromMemAndBranchIfNegative for riscv64. r=jandem

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/65687cb06be0
https://hg.mozilla.org/mozilla-central/rev/35e0c5b79ded