1975645 - MacroAssembler-riscv64: Cleanup unimplemented methods that block jit-test

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[Rong Bao [:csmantle]]

This bug covers the unimplemented MOZ_CRASHes that directly affects the pass rate of jit-test on riscv64 simulator and native platforms.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Bug 1975645 - [riscv64] Part 1: Enable MacroAssembler::debugAssertCanonicalInt32 code generation. r=jandem

Comment 2

[Rong Bao [:csmantle]]

Attachment: Bug 1975645 - [riscv64] Part 2: Implement MacroAssembler::branchTestPtr. r=jandem

Comment 3

[Rong Bao [:csmantle]]

Attachment: Bug 1975645 - [riscv64] Part 3: Implement MacroAssembler::move8ZeroExtend. r=jandem

Comment 4

[Rong Bao [:csmantle]]

Attachment: Bug 1975645 - [riscv64] Part 4: Implement overloads of MacroAssembler::test32MovePtr. r=jandem

Comment 5

[Rong Bao [:csmantle]]

Marking this as blocking bug 1933206 since this also affects native builds.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9aa51d7bc290
https://hg.mozilla.org/integration/autoland/rev/b4d643d029e7
[riscv64] Part 1: Enable MacroAssembler::debugAssertCanonicalInt32 code generation. r=jandem
https://github.com/mozilla-firefox/firefox/commit/bfeb723048a8
https://hg.mozilla.org/integration/autoland/rev/4de22ed69a61
[riscv64] Part 2: Implement MacroAssembler::branchTestPtr. r=jandem
https://github.com/mozilla-firefox/firefox/commit/1dbdc6c44e75
https://hg.mozilla.org/integration/autoland/rev/af7162248a45
[riscv64] Part 3: Implement MacroAssembler::move8ZeroExtend. r=jandem
https://github.com/mozilla-firefox/firefox/commit/5811ecf748d5
https://hg.mozilla.org/integration/autoland/rev/678b835cda1b
[riscv64] Part 4: Implement overloads of MacroAssembler::test32MovePtr. r=jandem

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b4d643d029e7
https://hg.mozilla.org/mozilla-central/rev/4de22ed69a61
https://hg.mozilla.org/mozilla-central/rev/af7162248a45
https://hg.mozilla.org/mozilla-central/rev/678b835cda1b