1975714 - Message queueing follow-ups

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P1)

Description

[Teodor Tanasoaia [:teoxoy]]

Follow-ups to Bug 1968122, mainly addressing issues brought up in reviews.

Comment 1

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Correct comments. r=#webgpu-reviewers

Comment 2

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Do not immediately resolve the lost promise on `device.destroy()`. r=#webgpu-reviewers

We can't immediately resolve the lost promise on device.destroy()
since it has to be well-ordered with the resolution of other promises.

I previously mentioned I had to demote 2 tests from tier 2 because I
thought they were relying on promise ordering that the spec doesn't
guarantee. Looking at the spec more throughly it turns out that the
specific steps outlined in the spec do guarantee the ordering but
the more succint "Promise Ordering" section does not mention this.

Tests in question:
https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,state,device_lost,destroy:createComputePipelineAsync:*
https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,state,device_lost,destroy:createRenderPipelineAsync:*

Comment 3

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Make sure to resolve/reject all pending promises in `ClearActorState`. r=#webgpu-reviewers

Comment 4

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Turn function pointers into extern fns. r=#webgpu-reviewers

Comment 5

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Remove unneeded `#[allow(dead_code)]`. r=#webgpu-reviewers

Comment 6

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Use an opaque pointer for `WebGPUParent`. r=#webgpu-reviewers

Comment 7

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Use `FfiSlice` in remaining places. r=#webgpu-reviewers

Comment 8

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Replace uses of `make_slice` with `FfiSlice`. r=#webgpu-reviewers

Comment 9

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Move remaining ID creation/destruction into resource creation/destruction functions. r=#webgpu-reviewers

Comment 10

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Assert that the IDs in server messages are the same as the ones the `WebGPUChild` actor expects. r=#webgpu-reviewers

Comment 11

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Use `MOZ_CAN_RUN_SCRIPT_BOUNDARY` for `reportCompilationMessagesToConsole`. r=#webgpu-reviewers

Comment 12

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Update backlog expectations. r=#webgpu-reviewers

Most of the new passes are due to us now rejecting async pipeline creation promises with the correct error (GPUPipelineError).

Comment 13

[Teodor Tanasoaia [:teoxoy]]

Attachment: Bug 1975714 - Promote tests out of backlog. r=#webgpu-reviewers

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e0aabda0e9f
https://hg.mozilla.org/integration/autoland/rev/b2984c7728bc
Correct comments. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/1c10e1f69846
https://hg.mozilla.org/integration/autoland/rev/6ea51872675f
Do not immediately resolve the lost promise on `device.destroy()`. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/2f607174ce94
https://hg.mozilla.org/integration/autoland/rev/0991a135f9ae
Make sure to resolve/reject all pending promises in `ClearActorState`. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/d3681b7012a2
https://hg.mozilla.org/integration/autoland/rev/5dba8587c1e8
Turn function pointers into extern fns. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/a84b40d4b825
https://hg.mozilla.org/integration/autoland/rev/ac3f857e4f14
Remove unneeded `#[allow(dead_code)]`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/bf83ea6553c8
https://hg.mozilla.org/integration/autoland/rev/1cbe710f0fcb
Use an opaque pointer for `WebGPUParent`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/3812af72dd21
https://hg.mozilla.org/integration/autoland/rev/204cc03845a4
Use `FfiSlice` in remaining places. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/62add844bff1
https://hg.mozilla.org/integration/autoland/rev/171bb86cf787
Replace uses of `make_slice` with  `FfiSlice`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/122e1a6529e0
https://hg.mozilla.org/integration/autoland/rev/416f16a0e3c3
Move remaining ID creation/destruction into resource creation/destruction functions. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/5ce8cf9b12b4
https://hg.mozilla.org/integration/autoland/rev/1915dee15a18
Assert that the IDs in server messages are the same as the ones the `WebGPUChild` actor expects. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/4394625f9300
https://hg.mozilla.org/integration/autoland/rev/cd44a8e497c2
Use `MOZ_CAN_RUN_SCRIPT_BOUNDARY` for `reportCompilationMessagesToConsole`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/72b4644a09df
https://hg.mozilla.org/integration/autoland/rev/bd6ff3bf373d
Update backlog expectations. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/22fb6f2691ec
https://hg.mozilla.org/integration/autoland/rev/44321c554f1f
Promote tests out of backlog. r=webgpu-reviewers,nical

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/752f8e9d7d07
https://hg.mozilla.org/integration/autoland/rev/2c28b9cc7958
Revert "Bug 1975714 - Promote tests out of backlog. r=webgpu-reviewers,nical" for causing build bustages @ ComputePassEncoder.cpp

Comment 16

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ ComputePassEncoder.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c28b9cc7958a8e70082af1bf460dc10b8fed061

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/dom/webgpu/ComputePassEncoder.cpp(71,56): error: non-constant-expression cannot be narrowed from type 'uint64_t' (aka 'unsigned long long') to 'uintptr_t' (aka 'unsigned int') in initializer list

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1fb3f15d688
https://hg.mozilla.org/integration/autoland/rev/6a603737cd3b
Correct comments. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/3f1ce44081bc
https://hg.mozilla.org/integration/autoland/rev/3eaca7e39df9
Do not immediately resolve the lost promise on `device.destroy()`. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/9a7ba3ec792d
https://hg.mozilla.org/integration/autoland/rev/516dbb695466
Make sure to resolve/reject all pending promises in `ClearActorState`. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/97fdd1fd3245
https://hg.mozilla.org/integration/autoland/rev/9da0b548679b
Turn function pointers into extern fns. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/64f9bdcddcd8
https://hg.mozilla.org/integration/autoland/rev/75c05347f9cd
Remove unneeded `#[allow(dead_code)]`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/5fe58ae76794
https://hg.mozilla.org/integration/autoland/rev/27ea7465eb6c
Use an opaque pointer for `WebGPUParent`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/1dbaf92aeca9
https://hg.mozilla.org/integration/autoland/rev/93e62f967dbd
Use `FfiSlice` in remaining places. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/c10f7dd0fc7e
https://hg.mozilla.org/integration/autoland/rev/a8b3ec80998f
Replace uses of `make_slice` with  `FfiSlice`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/2ed25cea011a
https://hg.mozilla.org/integration/autoland/rev/adff87de88aa
Move remaining ID creation/destruction into resource creation/destruction functions. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/3ba482a27966
https://hg.mozilla.org/integration/autoland/rev/d20e5910cdbf
Assert that the IDs in server messages are the same as the ones the `WebGPUChild` actor expects. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/db421a583d61
https://hg.mozilla.org/integration/autoland/rev/ef60c31a43b2
Use `MOZ_CAN_RUN_SCRIPT_BOUNDARY` for `reportCompilationMessagesToConsole`. r=webgpu-reviewers,ErichDonGubler
https://github.com/mozilla-firefox/firefox/commit/e4b2845d2bec
https://hg.mozilla.org/integration/autoland/rev/0594b5f63104
Update backlog expectations. r=webgpu-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/2f1472f8ce1f
https://hg.mozilla.org/integration/autoland/rev/e599fad2ef50
Promote tests out of backlog. r=webgpu-reviewers,nical

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6a603737cd3b
https://hg.mozilla.org/mozilla-central/rev/3eaca7e39df9
https://hg.mozilla.org/mozilla-central/rev/516dbb695466
https://hg.mozilla.org/mozilla-central/rev/9da0b548679b
https://hg.mozilla.org/mozilla-central/rev/75c05347f9cd
https://hg.mozilla.org/mozilla-central/rev/27ea7465eb6c
https://hg.mozilla.org/mozilla-central/rev/93e62f967dbd
https://hg.mozilla.org/mozilla-central/rev/a8b3ec80998f
https://hg.mozilla.org/mozilla-central/rev/adff87de88aa
https://hg.mozilla.org/mozilla-central/rev/d20e5910cdbf
https://hg.mozilla.org/mozilla-central/rev/ef60c31a43b2
https://hg.mozilla.org/mozilla-central/rev/0594b5f63104
https://hg.mozilla.org/mozilla-central/rev/e599fad2ef50