1975762 - Generate a settings sub-page from a group of config-based settings

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Mark Striemer [:mstriemer]]

We will need to generate an entire sub-page from the config-based settings. These will require all the details that a page does (bug 1975761) but it also needs a parent page/sub-page

Sub-pages will additionally include breadcrumbs to go back to the parent page

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1975762 - Part 1: Support sub-pages in config-based prefs r?#settings-reviewers

Comment 2

[Mark Striemer [:mstriemer]]

Going to land the changes and follow up with the test after so it's not blocking other patches

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7494954412d
https://hg.mozilla.org/integration/autoland/rev/61ae98129859
Part 1: Support sub-pages in config-based prefs r=desktop-theme-reviewers,tgiles

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/61ae98129859

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1975762 - Tests for setting-pane sub pages r?#settings-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12b4adb7efa5
https://hg.mozilla.org/integration/autoland/rev/2bcdbf3369c7
Tests for setting-pane sub pages r=desktop-theme-reviewers,mconley,tgiles

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5bd38320f8e6
https://hg.mozilla.org/integration/autoland/rev/98a6999ddf33
Revert "Bug 1975762 - Tests for setting-pane sub pages r=desktop-theme-reviewers,mconley,tgiles" for causing mochites failure on browser_HCM_telemetry.js

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for causing mochites failure on browser_HCM_telemetry.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/98a6999ddf335a8e40f72e6d0f421e619629a806
Log link: https://treeherder.mozilla.org/logviewer?job_id=535794608&repo=autoland&task=DDXK8n8tSyyhZ_GQDqYIOA.0&lineNumber=2366

There were also:

• failures on browser_defaultbrowser_alwayscheck.js
• failures on test_preferencesBindings_setting.html
• failures on sanitize/browser_sanitizeDialog_v2.js
• failures on test_preferencesBindings_setting.html
• failures on test_setting_control.html

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf10e9399e97
https://hg.mozilla.org/integration/autoland/rev/83e96861b0f6
Tests for setting-pane sub pages r=desktop-theme-reviewers,mconley,tgiles

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/83e96861b0f6

Comment 11

[Francesco Lodolo [:flod]]

I can see hardcoded text (at least Manage container settings) in Settings. Is this expected?

Comment 12

[Mark Striemer [:mstriemer]]

Yes, this was placeholder data to have an example in-tree of how to use this feature. We have real uses now so it can be removed.

Comment 13

[Mark Striemer [:mstriemer]]

The placeholder data is behind a pref, to be clear