Closed
Bug 1975802
Opened 7 months ago
Closed 5 months ago
Don't suggest uplift form if nothing was submitted
Categories
(Conduit :: moz-phab, enhancement)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mathew.hodson, Assigned: mathew.hodson)
Details
Attachments
(1 file)
moz-phab version (from moz-phab version): MozPhab 1.11.0 (Python 3.9.13, Windows)
When using moz-phab uplift there is a message that reminds you to fill out the form on Phabricator, but the message is shown even if you cancel the submit or there is some other error.
It would make more sense to only show the message after commits are actually submitted.
|
Assignee | |
Comment 1•7 months ago
|
||
|
||
Updated•6 months ago
|
Attachment #9498687 -
Attachment description: Don't suggest uplift form if nothing was submitted (Bug 1975802) r=sheehan → uplift: don't suggest uplift form if nothing was submitted (Bug 1975802) r=sheehan
|
|
Assignee | |
Updated•6 months ago
|
Assignee: mathew.hodson → nobody
|
|
||
Updated•6 months ago
|
Attachment #9498687 -
Attachment is obsolete: true
|
|
||
Updated•5 months ago
|
Assignee: nobody → mathew.hodson
Attachment #9498687 -
Attachment description: uplift: don't suggest uplift form if nothing was submitted (Bug 1975802) r=sheehan → uplift: don't suggest uplift form if nothing was submitted (Bug 1975802)
Attachment #9498687 -
Attachment is obsolete: false
Status: NEW → ASSIGNED
|
||
Comment 2•5 months ago
|
||
Authored by https://github.com/mathewhodson
https://github.com/mozilla-conduit/review/commit/8ae4315c239daa889f513f490b9cfb9d8e4bd8f5
[main] uplift: don't suggest uplift form if nothing was submitted (Bug 1975802) r=sheehan
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•