1975851 - RFP: enforce navigator.onLine as always true

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Thorin [:thorin]]

Attachment: TZP TB onLine.png

If users toggle Menu>File>Work Offline they create entropy. I don't even know how useful this menu item is - but it's a footgun. The menu is enabled by default on some platforms IIRC, but of course the fact that it can be enabled by the user and the setting is accessible, it is a footgun

edit the attached image is Tor Browser with Work Offline toggle to true end edit

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/onLine

Suggested enhancement to enforce true behind RFP (RFPTarget NetworkConnection ?)

Also see Bug 1614804 which I also suggest we can close as WONTFIX (see supported in MDN link) as removing the navigator property will just cause webcompat issues

Comment 1

[Fatih Kilic [:fkilic]]

Attachment: Bug 1975851 - Enforce navigator.onLine as always true in RFP. r?tjr

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab9b8e15b3e5
https://hg.mozilla.org/integration/autoland/rev/cf4693602954
Enforce navigator.onLine as always true in RFP. r=tjr

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cf4693602954

Comment 4

[Thorin [:thorin]]

Attachment: verified.jpg

verified via top level document

do we want to backport this to ESR140 for Tor Browser

Comment 5

[Fatih Kilic [:fkilic]]

Attachment: Bug 1975851 - Enforce navigator.onLine as always true in RFP. r?tjr

Original Revision: https://phabricator.services.mozilla.com/D256508

Comment 6

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Only affects "Resist Fingerprinting" users. Firefox doesn't support this configuration. We are requesting the uplift for Tor Browser.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Click on Menu>File>Work Offline, run navigator.onLine and verify it returns false. Then, change these prefs accordingly privacy.fingerprintingProtection=true and privacy.fingerprintingProtection.overrides = -AllTargets,+NetworkConnection. Then run navigator.onLine again and verify it is true
• Risk associated with taking this patch: None
• Explanation of risk level: N/A
• String changes made/needed: No
• Is Android affected?: yes

Comment 7

[Fatih Kilic [:fkilic]]

Requested

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/6877adce8a8c