Closed
Bug 1975872
Opened 6 months ago
Closed 5 months ago
Certain `testGetValue` calls in browser/components/preferences/tests are unnecessarily awaited
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: scunnane, Assigned: rtlo9962, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
The two calls to testGetValue in browser/components/preferences/tests/browser_searchDefaultEngine.js don't need to be awaited.
And in browser/components/preferences/tests/browser_sync_chooseWhatToSync.js, this testGetValue call doesn't need to be awaited. (And thus the enclosing callback doesn't need to be marked async either.)
Note: I will be assigning this bug to a new Firefox contributor shortly as a good first bug.
|
Reporter | |
Updated•6 months ago
|
Summary: `testGetValue` calls in browser/components/preferences/tests/browser_searchDefaultEngine.js are unnecessarily awaited → Certain `testGetValue` calls in browser/components/preferences/tests are unnecessarily awaited
|
||
Updated•6 months ago
|
Type: defect → task
|
Assignee | |
Comment 1•6 months ago
|
||
|
||
Updated•6 months ago
|
Attachment #9499037 -
Attachment description: WIP: Bug 1975872 - Certain `testGetValue` calls in browser/components/preferences/tests are unnecessarily awaited → WIP: Bug 1975872 - Remove await/async from testGetValue() calls
|
|
Assignee | |
Comment 2•6 months ago
|
||
I’m a new contributor, and I’ll be submitting a patch for this bug soon
|
|
Reporter | |
Updated•6 months ago
|
Assignee: nobody → rtlo9962
|
|
||
Updated•6 months ago
|
Attachment #9499037 -
Attachment description: WIP: Bug 1975872 - Remove await/async from testGetValue() calls → Bug 1975872 - Remove unnecessary awaits from certain 'testGetValue' calls in browser/components/preferences/tests. r?#preferences-reviewers!
Pushed by gijskruitbosch@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/3eaa88890fa8
https://hg.mozilla.org/integration/autoland/rev/057393172031
Remove unnecessary awaits from certain 'testGetValue' calls in browser/components/preferences/tests. r=settings-reviewers,Gijs
|
||
Comment 4•5 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
|
||
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•