1976242 - Unenrolling and re-enrolling quickly will fail to serialize to the database correctly.

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Beth Rennie [:beth] (she/her)]

STR:

1. Enroll in a rollout
2. Wait for enrollments to flush to disk
3. Unenroll from the rollout
4. Re-enroll in the rollout
5. Restart the browser

ER:

The rollout should be enrolled

AR:

The rollout is not marked as enrolled but it if it set any user prefs (via setPref) those prefs will still be set.

This really only affects enrollments that occur with Nimbus Developer Tools or Firefox Labs because there isn't a real scenario where an unenrollment would be followed by a re-enrollment during natural enrollment.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971425

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1976242 - Always serialize re-enrollments correctly r?#nimbus-reviewers

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1976242 - Always serialize re-enrollments correctly r?#nimbus-reviewers

Original Revision: https://phabricator.services.mozilla.com/D256460

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users that unenroll and re-enroll in Firefox Labs rollouts will not be re-enrolled upon restart and the prefs will be stuck on
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: patch contains a test that fails without the patch applied
• String changes made/needed: no
• Is Android affected?: no

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users that unenroll and re-enroll in Firefox Labs rollouts will not be re-enrolled upon restart and the prefs will be stuck on
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: patch contains a test that fails without the patch applied
• String changes made/needed: no
• Is Android affected?: no

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/63418dc7c266
https://hg.mozilla.org/integration/autoland/rev/e0bdeb9fde67
Always serialize re-enrollments correctly r=nimbus-reviewers,emcminn

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e0bdeb9fde67

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/04f77e6e19c3
https://hg.mozilla.org/releases/mozilla-beta/rev/2e967b7fac03

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f0d8ad2335f6
https://hg.mozilla.org/releases/mozilla-beta/rev/8b99846afb43
Lint fix