1976282 - [wpt-sync] Sync PR 53657 - Block-in-inline: Stay in parallel flow, once established.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53657
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Block-in-inline: Stay in parallel flow, once established.

When a block has been overflowed, we normally establish a parallel
fragmentation flow for content inside it, but this is disabled if
preceded by a column spanner. If the column spanner is discovered "too"
late, we may have entered a parallel flow. Then stay in this parallel
flow even if a spanner is discovered, or else the outgoing break tokens
are lost. It could be that the inline layout algorithm ought to be
refactored to handle this better, but this is all thanks to
crbug.com/430249827 and is a situation that should never occur, so
probably not worth it.

Also update a DCHECK, so that it makes the same exception for inline
break tokens as it already did for block break tokens.

Bug: 364933065
Change-Id: I5051ca952f6247f691b956f68111a9d811158de7
Reviewed-on: https://chromium-review.googlesource.com/6714627
WPT-Export-Revision: 9fcbabb14db5391bb02f54afe6dc86dd8bda7bba

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24617da32e2e60735457fb87d6b1e16316b4e0db

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Chrome

PASS : 1
CRASH: 1

Safari

PASS : 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b14eb238d6b1
https://hg.mozilla.org/integration/autoland/rev/2c528ab1301a
[wpt PR 53657] - Block-in-inline: Stay in parallel flow, once established., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c528ab1301a