1976422 - 'mach mochitest --android' parameter is not working

Status: NEW

(Testing :: Mochitest, defect, P2)

Description

[Mark Banner (:standard8)]

I believe the --android parameter that was added in bug 1959767 may not be working properly after bug 1975866 lands, but I'm not quite sure as I don't have a set-up to test it.

The background is that it was originally added in bug 1959767, and we later landed bug 1970951 to fix --help. Then we discovered that ./mach mochitest path/to/test was ignoring the test, and I am fixing that in bug 1975866.

However, we also noticed that at the start of the build_args function, there are these couple of lines:

        if args and not self.app and any("--android" == arg for arg in args):
            self.app = "android"

build_args is never passed any parameters, so this is either unused or it is broken.

Running ./mach mochitest --android locally does seem to switch it into Android mode, though ./mach mochitest --android --remote-webserver doesn't recognise the arguments.

I think what we might need to do is add a check in parse_known_args, so that if --android is set, then add the AndroidArguments list.

We would still want to keep the rest of build_args as it is because that's needed to make --help work, and if we're auto-detecting the build as Android, then we should still be able to display the android specific arguments.

I think that would work for all cases, but I don't have time to work on a patch at the moment.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jmaher, could you have a look please?

For more information, please visit BugBot documentation.