Closed
Bug 1976479
Opened 5 months ago
Closed 5 months ago
Consider adding uploader_capabilities string list instrumentation to pings
Categories
(Data Platform and Tools :: Glean: SDK, enhancement, P1)
Data Platform and Tools
Glean: SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chutten|PTO, Assigned: janerik)
References
(Blocks 1 open bug)
Details
(Whiteboard: [telemetry:glean-rs:testing])
Attachments
(2 files)
|
42 bytes,
text/x-github-pull-request
|
Details | Review | |
|
2.54 KB,
text/plain
|
travis_
:
data-review+
|
Details |
Right now it's tough to validate that any given received ping was uploaded with any given combination of uploader_capabilities. On the client we have assurances (we know what was compiled in from pings.yaml and we know what was stored to disk), but once the ping leaves the client there's nothing about it that says one way or another.
It seems as though we should instrument the uploader_capabilities so that pings uploaded with them are annotated with them.
The fun piece might be figuring out where to put this instrumentation:
ping_infofeels like the right place, but someuploader_capabilities(notably ones that contain'ohttp') requireinclude_info_sections: false- putting it in the payload: we'd have to be careful about timing it for when the ping is submitted in case the
uploader_capabilitiesunder which the ping was created do not match those when it gets handed to the uploader. This might make testing difficult when usingtest_before_next_submit. - putting it in a header could be tricky to 1) make certain it's available in the data afterwards (I think
metadata.headerswould be straightforward to augment, but I've not done it before), and 2) make certain it's in the correct headers that'll make it through all the encode and decode steps that might be required for combinations ofuploader_capabilities
Comment 1•5 months ago
|
||
| Assignee | ||
Updated•5 months ago
|
Assignee: nobody → jrediger
Priority: -- → P1
| Assignee | ||
Comment 2•5 months ago
|
||
Attachment #9502690 -
Flags: data-review?(tlong)
Comment 3•5 months ago
|
||
Comment on attachment 9502690 [details]
data-review-1976479.md
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
- Yes, via the Glean Dictionary
- Is there a control mechanism that allows the user to turn the data collection on and off?
- Yes, the application settings provide data collection opt-out choices.
- If the request is for permanent data collection, is there someone who will monitor the data over time?
- Permanent collection to be monitored by Jan-Erik, backed by glean-team@mozilla.com
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
- Category 1 - Technical
- Is the data collection request for default-on or default-off?
- default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc.
- No
- Is the data collection covered by the existing Firefox privacy notice?
- Yes
- Does the data collection use a third-party collection tool?
- No
Result
data-review+
Attachment #9502690 -
Flags: data-review?(tlong) → data-review+
| Assignee | ||
Comment 4•5 months ago
|
||
badboy merged PR [mozilla/glean]: Bug 1976479 - Report a glean.ping.uploader_capabilities list in pings (#3188) in c18fb12.
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•