1976480 - ‘Copy Link to Highlight’ selects additional text

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: quotehighlight.gif

Found in

• Nightly 142.0a1;

Affected versions

• Nightly 142.0a1;

Tested platforms

• Windows 10;
• macOS 15;
• Ubuntu 22;

Affected platforms

• Windows 10;
• macOS 15;
• Ubuntu 22;

Unaffected platforms

• N/A;

Preconditions

• dom.text_fragments.enabled to TRUE
• dom.text_fragments.create_text_fragment.enabled set to TRUE

Steps to reproduce

1. Launch Firefox.
2. Go to https://en.wikipedia.org/wiki/Percent-encoding
3. Select the double quotation mark - “ .
4. Right-click on the selection and select ‘Copy Link to Highlight’.
5. Open a new tab and paste the link in the address bar.
6. Observe the highlighted paragraphs in the page.

Expected result

• Only the quotation mark is highlighted.

Actual result

• Highlight is also applied to the first word after the quotation mark.

Regression range

• Not a regression.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1976480 - Text Fragments: Don't extend the selection if only punctuation is selected. r=#dom-core!

This patch adds a new check in the beginning of the algorithm which leaves the
input range unchanged if its content is only punctuation characters.
This edge case is handled by checking if all characters are punctuation and would return early, hence not going into the algorithm that extends the range to word boundaries
(which would become more complex trying to achieve the same).

Additionally, this patch contains a minor refactoring: Other edge cases in the input range
(empty range, whitespace-only ranges) are moved into the function that extends the
range to word boundaries.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/57ee7d95ea71
https://hg.mozilla.org/integration/autoland/rev/79170f140f14
Text Fragments: Don't extend the selection if only punctuation is selected. r=dom-core,avandolder,mccr8

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/79170f140f14

Comment 4

[Adrian Florinescu [:aflorinescu]]

Verified during 143 Nightly testing on Mac and Ubuntu with additional manual verification for Windows.