1976490 - `addon-install-error-file-access` string doesn't (always?) have an add-on name

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[William Durand [:willdurand]]

Attachment: popup screenshot from reddit

In https://www.reddit.com/r/firefox/comments/1lv9aaj/unable_to_add_firefox_extensions/, I noticed one of the screenshots was displayed an odd popup (cf. attached screenshot). It looks like $addonName isn't replaced because there is no add-on name, likely because we cannot read it from the file.

We should probably change that string to not include the add-on name since we might never have an add-on name. This specific error is set here: https://searchfox.org/mozilla-central/rev/b63f8c50a3398aff80d2a5f185a90dcdba47f419/toolkit/mozapps/extensions/internal/XPIInstall.sys.mjs#2475

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1976490 - Add new variants for the `addon-install-error-file-access` string when the add-on name is missing. r?rpl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b16078bfdda
https://hg.mozilla.org/integration/autoland/rev/d256d2155ab4
Add new variants for the `addon-install-error-file-access` string when the add-on name is missing. r=rpl,fluent-reviewers,bolsson

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d256d2155ab4