197656 - codesighs test doesn't handle objdirs

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Bradley Baetz (:bbaetz)]

Like the rest of the places which ask for an objdir, the -o option passed to
codesighs (which requires cls' not-yet-checked-in patches) needs to prepend the
srcdir

The patch I'll attach is working on brad/brad-fast, but needs sanity-testing on
a non-objdir build.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: fix

$objdir could probably be used in other places in the file, but....

Comment 2

[hacker formerly known as [e-mail]]

Attachment: make codesigh scripts objdir aware

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 117375 [details] [diff] [review]
fix

r=cls

Comment 4

[Bradley Baetz (:bbaetz)]

attachment 117375 [details] [diff] [review] checked in. (cls fixed the absolute-objdir case last night)

Comment 5

[Alec Flett]

Comment on attachment 117376 [details] [diff] [review]
make codesigh scripts objdir aware

comments people! This looks fine but add some comments explaining the "shift
shift" stuff..sr=alecf with that.

Comment 6

[Bradley Baetz (:bbaetz)]

cls, can you handle checking this in? Thanks!

Comment 7

[hacker formerly known as [e-mail]]

Patch checked in with comments added.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This didn't quite work for me on Windows.  I filed bug 207802 with the
additional patch I needed (to transform /cygdrive/d/... paths into d:/...
paths).  (dumpbin didn't like the cygdrive paths -- it thought they were
command-line options.)