1976570 - Debugger hangs in sources tree reducer when processing many sources

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

Using bug 1653779 comment 17 highlight a performance bottleneck in sources tree reducer when registering many sources.
https://share.firefox.dev/40InQFy

This come from this function which would lookup for the parent directory for each source.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1976570 - [devtools] Speedup debugger with many sources in the same folder. r=#devtools

This avoid the lookup of a nested folder in the tree for each individual source.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1976570 - [devtools] Stop computing and storing a url for each source tree item. r=#devtools

This data is only used by the project directory root and only for a tooltip.
This should rather be computed on-demand.

This also address a shortcoming when a source was using / in query parameters.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/23dc2a2b8bc9
https://hg.mozilla.org/integration/autoland/rev/6aa9ddad6be4
[devtools] Speedup debugger with many sources in the same folder. r=devtools-reviewers,nchevobbe
https://github.com/mozilla-firefox/firefox/commit/cb2e5950c141
https://hg.mozilla.org/integration/autoland/rev/a5ddf396b9b5
[devtools] Stop computing and storing a url for each source tree item. r=devtools-reviewers,bomsy

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6aa9ddad6be4
https://hg.mozilla.org/mozilla-central/rev/a5ddf396b9b5