1976694 - Remove the JavaScript based search engine selector

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Now that the Rust based engine selector is shipping, we should remove the older JavaScript based code and the associated preference.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1976694 - Remove the JavaScript based Search Engine Selector code. r?mcheang!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1976694 - Avoid keeping a copy of the search configuration overrides in memory in JavaScript. r?mcheang!

This get stored in Rust and don't need to be cached in JavaScript as well.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1976694 - Move some more SearchEngineSelector properties to be private. r?mcheang!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1976694 - Change SearchEngineSelector._configuration to be a private member. r?mcheang!

Comment 5

[Mark Banner (:standard8)]

Note, I've not removed the engine selector tests, we probably want to consider if we keep them or not, after bug 1949126 is completed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7bc0b18d9e8a
https://hg.mozilla.org/integration/autoland/rev/c6d8cffc2944
Remove the JavaScript based Search Engine Selector code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/fd2ff8a4edf2
https://hg.mozilla.org/integration/autoland/rev/a070a948cd2f
Avoid keeping a copy of the search configuration overrides in memory in JavaScript. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/535eb687c557
https://hg.mozilla.org/integration/autoland/rev/2a4e93b83fdc
Move some more SearchEngineSelector properties to be private. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/007be104d14b
https://hg.mozilla.org/integration/autoland/rev/47149a53fb5e
Change SearchEngineSelector._configuration to be a private member. r=mcheang

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a97aa9bd7674
https://hg.mozilla.org/integration/autoland/rev/4408830acf26
Revert "Bug 1976694 - Change SearchEngineSelector._configuration to be a private member. r=mcheang" for causing generate failures

Comment 8

[[e-mail]]

Backed out for causing generate failures

- Backout link
- Push with failures
- Failure log

failure line: sphinx.errors.ExtensionError: Handler <function analyze at 0x7f611cfcdd00> for event 'builder-inited' threw an exception (exception: Your code contains multiple documented objects at each of these paths:

Comment 9

[Mark Banner (:standard8)]

Had to stop the document updates processing some of the search modules, to avoid issues with the document update mechanism - we don't currently generate document summaries for those modules, so it doesn't affect what we're currently publishing on Firefox source docs.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/281f462fb070
https://hg.mozilla.org/integration/autoland/rev/86680948aaba
Move some more SearchEngineSelector properties to be private. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/c961941b3eb6
https://hg.mozilla.org/integration/autoland/rev/886dbf2c86b2
Change SearchEngineSelector._configuration to be a private member. r=mcheang

Comment 11

[Andrej (:aglavic)]

Attachment: Revert "Bug 1976694 - Change SearchEngineSelector._configuration to be a private member. r=mcheang" for causing generate failures

This reverts commit 007be104d14b712d0cb0011d2b01130a2dba0cbd.

Revert "Bug 1976694 - Move some more SearchEngineSelector properties to be private. r=mcheang"

This reverts commit 535eb687c5574eb9bd3ffea8e454d5606901aa5d.

Comment 12

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/86680948aaba
https://hg.mozilla.org/mozilla-central/rev/886dbf2c86b2