1976703 - Replace UITour references to `nsISearchEngine.identifier` with `id`

Status: RESOLVED FIXED

(Firefox :: Tours, task)

Description

[Mark Banner (:standard8)]

In bug 1877721, we'd like to remove nsISearchEngine.identifier as it is ambiguous with what it is, and overlaps with id and telemetryId.

The UITour code currently uses it in two places:

• getConfiguration.
  • The sendPageCallback is called with an object, containing a searchEngineIdentifier and a list of engines.
    • searchEngineIdentifier can be replaced by a check for application (config) engine & returning id if it is, or null, if not.
    • The engines list should be filtered by application (config) engine and then also use id instead of identifier. Note that the filtering for visible engines should be kept.
• setDefaultSearchEngine should use the newer nsISearchEngine.getEngineById function rather than handling its own lookup.

As far as we can tell, the Bedrock website code doesn't use these currently (getConfiguration, setDefaultSearchEngine), hence we should be fine to update these.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1976703 - Change UITour to use the search engine id rather than an id which includes a telemetry suffix. r?#omc-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77f1160f6eed
https://hg.mozilla.org/integration/autoland/rev/d8d0bc4713c3
Change UITour to use the search engine id rather than an id which includes a telemetry suffix. r=omc-reviewers,pdahiya

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/d8d0bc4713c3