1976871 - Update PDF.js to new version 2e0f1ec51569de729c12801be811d709fe2e6e67 from 2025-07-09 16:09:26

Status: RESOLVED WONTFIX

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 16 commits. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.mjs | 115 +++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 340 +++++++------
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 4 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 56 +-
toolkit/components/pdfjs/content/web/viewer.css | 30 +-
toolkit/components/pdfjs/content/web/viewer.html | 3 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 86 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
toolkit/locales/en-US/toolkit/pdfviewer/viewer.ftl | 8 +
10 files changed, 377 insertions(+), 273 deletions(-)

---

e36f58ee4d2ba48c5cde166a25ddb4dac92d4dd4 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/e36f58ee4d2ba48c5cde166a25ddb4dac92d4dd4
Authored: 2025-07-09 17:38:49 +0200
Committed: 2025-07-09 17:38:49 +0200

Revert "Make horizontal padding relative to device width"

This reverts commit c138887c1f7613bce44b99d22b63e2d744b0fb40.

Files Modified:

• test/integration/find_spec.mjs
• web/pdf_find_controller.js
• web/ui_utils.js

---

1d702d4d6d7ac1dd6188f11a1f162d0c8f093f04 by Ujjwal Sharma <[e-mail]>

https://github.com/mozilla/pdf.js/+/1d702d4d6d7ac1dd6188f11a1f162d0c8f093f04
Authored: 2025-07-08 23:27:41 +0200
Committed: 2025-07-08 23:27:41 +0200

Bump library version to 5.4

Files Modified:

• pdfjs.config

---

63b37b4371624d0787203630cb5db484d014b532 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/63b37b4371624d0787203630cb5db484d014b532
Authored: 2025-07-07 20:40:16 +0200
Committed: 2025-07-08 21:23:29 +0200

Add few methods to the Dict class in order to simplify the code when writing an annotation

Files Modified:

• src/core/annotation.js
• src/core/core_utils.js
• src/core/default_appearance.js
• src/core/primitives.js
• src/core/writer.js
• test/unit/core_utils_spec.js
• test/unit/primitives_spec.js

---

ecc7096a805979a88d117dd139fcd69ddf07b025 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/ecc7096a805979a88d117dd139fcd69ddf07b025
Authored: 2025-07-07 11:44:03 +0200
Committed: 2025-07-08 20:51:58 +0200

Fix the default appearance of a Polygon annotation when a fill color is provided

It fixes #20062.

Files Added:

• test/pdfs/issue20062.pdf

Files Modified:

• src/core/annotation.js
• test/pdfs/.gitignore
• test/test_manifest.json

---

bb52a440cece170d5695c892c9225ce7d3bd63fd by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/bb52a440cece170d5695c892c9225ce7d3bd63fd
Authored: 2025-07-04 21:17:21 +0200
Committed: 2025-07-07 10:51:35 +0200

Use the creation date in the popup when there is no modification date

Remove the h1 element in popup title because it caused a warning in Firefox and use a span instead.

Files Added:

• test/pdfs/firefox_logo.pdf

Files Modified:

• src/core/annotation.js
• src/display/annotation_layer.js
• test/pdfs/.gitignore
• test/test_manifest.json
• web/annotation_layer_builder.css

---

fa568e826d39ec0ed28e8934d7c2b6e32ff6df22 by Noritaka Kobayashi <[e-mail]>

https://github.com/mozilla/pdf.js/+/fa568e826d39ec0ed28e8934d7c2b6e32ff6df22
Authored: 2025-07-07 09:59:36 +0900
Committed: 2025-07-07 09:59:36 +0900

Fix typos across the codebase

Files Modified:

• extensions/chromium/pdfHandler.js
• src/core/annotation.js
• src/core/evaluator.js
• src/core/fonts.js
• src/core/image.js
• src/core/image_resizer.js
• src/core/xfa/formcalc_parser.js
• src/display/canvas.js
• src/display/editor/annotation_editor_layer.js
• src/shared/util.js
• test/driver.js
• test/integration/stamp_editor_spec.mjs
• web/event_utils.js
• web/pdf_find_controller.js

---

be1f5fe00914d8ad7e844ef4b55430355fd6dd08 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/be1f5fe00914d8ad7e844ef4b55430355fd6dd08
Authored: 2025-07-06 20:42:12 +0200
Committed: 2025-07-06 20:42:12 +0200

Bump the stable version in pdfjs.config

Files Modified:

• pdfjs.config

---

b1b728d47ff29384583136a08b74ec083786aee6 by Ujjwal Sharma <[e-mail]>

https://github.com/mozilla/pdf.js/+/b1b728d47ff29384583136a08b74ec083786aee6
Authored: 2025-06-17 14:41:33 +0200
Committed: 2025-07-04 00:53:51 +0200

[api-minor] Move getContext call to InternalRenderTask

This is a precursor to moving the call into a
worker thread to let us use OffscreenCanvas. The
current position wouldn't work since we make
transformations to the canvas object after the
getContext call, which isn't allowed for
OffscreenCanvas. Also it isn't allowed to clone or
transferControlToOffscreen the canvas after the
getContext call.

Files Added:

• test/integration/thumbnail_view_spec.mjs

Files Modified:

• src/display/api.js
• test/driver.js
• test/integration/jasmine-boot.js
• test/unit/api_spec.js
• test/unit/custom_spec.js
• web/base_pdf_page_view.js
• web/firefox_print_service.js
• web/pdf_page_detail_view.js
• web/pdf_page_view.js
• web/pdf_print_service.js
• web/pdf_thumbnail_view.js

---

6d2c6cfc9f0c34ddee7fb96ae7ce7c3800f2c416 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/6d2c6cfc9f0c34ddee7fb96ae7ce7c3800f2c416
Authored: 2025-07-03 20:04:24 +0200
Committed: 2025-07-03 23:27:34 +0200

[Editor] Allow to change the editor mode when selecting the corresponding editor (bug 1975538)

For example, selecting an ink editor just after having created a freetext will switch to ink mode.

Files Modified:

• src/display/annotation_layer.js
• src/display/editor/editor.js
• src/display/editor/tools.js
• test/integration/freetext_editor_spec.mjs
• web/pdf_viewer.js

---

c22a425b04ead23bff106ac63302c3a5f72d721b by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/c22a425b04ead23bff106ac63302c3a5f72d721b
Authored: 2025-07-02 20:04:55 +0200
Committed: 2025-07-03 16:53:01 +0200

[Editor] When an annotation is added, announce it if the user is using a screen reader (bug 1975264)

Files Modified:

• l10n/en-US/viewer.ftl
• src/display/editor/draw.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/ink.js
• src/display/editor/stamp.js
• src/display/editor/tools.js
• test/integration/freetext_editor_spec.mjs
• test/integration/highlight_editor_spec.mjs
• test/integration/ink_editor_spec.mjs
• test/integration/signature_editor_spec.mjs
• test/integration/stamp_editor_spec.mjs
• web/annotation_editor_layer_builder.css
• web/app.js
• web/pdf_viewer.js
• web/viewer.css
• web/viewer.html
• web/viewer.js

---

d8ecfad8bdf9b65bfdf645109c6ebe6aa47f5d5a by Yuyang Liu <[e-mail]>

https://github.com/mozilla/pdf.js/+/d8ecfad8bdf9b65bfdf645109c6ebe6aa47f5d5a
Authored: 2025-07-02 18:12:37 +0900
Committed: 2025-07-03 05:52:31 +0900

Make Popup annotations always have noRotate flag set as true

Necessary because when there is no Popup annotation created along
with a Text annotation, the Popup annotation created by pdf.js
does not receive the noRotate flag

Files Added:

• test/pdfs/pr20043.pdf

Files Modified:

• src/display/annotation_layer.js
• test/pdfs/.gitignore
• test/test_manifest.json

---

aaae5168946edb03d99e330a042dab8dfe9fbf4a by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/aaae5168946edb03d99e330a042dab8dfe9fbf4a
Authored: 2025-07-02 17:34:15 +0200
Committed: 2025-07-02 17:34:23 +0200

Don't focus the viewer at startup (bug 1974863)

It's useless and it causes screen readers to not always read the document title.

Files Modified:

• test/integration/test_utils.mjs
• test/integration/viewer_spec.mjs
• web/app.js

---

9acd16a0c78c11cdedc85ae6bce2fa091437812e by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/9acd16a0c78c11cdedc85ae6bce2fa091437812e
Authored: 2025-06-26 22:23:13 +0200
Committed: 2025-06-30 21:42:28 +0200

[Editor] In the signature modal, disable the save checkbox when the storage is full (bug 1974257)

Files Modified:

• test/integration/signature_editor_spec.mjs
• web/signature_manager.js
• web/viewer.html

---

fc9ba0cda3e825914bbb0da64c5a71a94ee9cf61 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/fc9ba0cda3e825914bbb0da64c5a71a94ee9cf61
Authored: 2025-06-27 16:13:38 +0200
Committed: 2025-06-30 21:39:22 +0200

Remove the shadow from the links (bug 1974436)

The shadow was taken into account when computing the bounding box of the section
containing the link and it was making the clip path wrong.
Since the shadow is almost invisible because of the opacity, the yellow color and the clip
we can remove it without causing any visual regressions (and as a side effect it'll avoid
to use resources to compute it when displayed).

Files Added:

• test/pdfs/bug1974436.pdf

Files Modified:

• test/pdfs/.gitignore
• test/test_manifest.json
• web/annotation_layer_builder.css

---

c138887c1f7613bce44b99d22b63e2d744b0fb40 by Aditi <[e-mail]>

https://github.com/mozilla/pdf.js/+/c138887c1f7613bce44b99d22b63e2d744b0fb40
Authored: 2025-06-25 19:59:25 +0530
Committed: 2025-06-30 19:08:02 +0530

Make horizontal padding relative to device width

The fixed -400px horizontal offset used by
scrollIntoView led to horizontal scroll only moving
part-way right on narrow screens. The highlights near
the right-edge remained party or completely off
screen.

This centres the highlighted match on any viewport width while
clamping the left margin to 20-400px. On very narrow screens
the scrollbar now moves all the way to the right instead of
stopping midway.

Files Modified:

• test/integration/find_spec.mjs
• web/pdf_find_controller.js
• web/ui_utils.js

---

bb6b42177cae20d8a064c60a3b3290499d37a7de by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/bb6b42177cae20d8a064c60a3b3290499d37a7de
Authored: 2025-06-26 18:53:56 +0200
Committed: 2025-06-26 18:55:59 +0200

Don't remove a dash at the end of a line when guessing urls (bug 1974112)

Files Modified:

• test/unit/autolinker_spec.js
• web/autolinker.js
• web/pdf_find_controller.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=ea29357dd8e11f9b5eacf930bb6598c385354321

Comment 2

[Update Bot]

Attachment: Bug 1976871 - Update PDF.js to 2e0f1ec51569de729c12801be811d709fe2e6e67

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• minidumpwriter exited with status: 1

  • 4 of 4 failed on the same (retriggered) task
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (TBG8CTZ6SYiWQYhU8kODRA)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (cJTxSc1aQ2SldZO9KwFafA)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (HF0nMuDIQFyTLsEiViBP0g)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (WN5RIWhYT2iAr_AqIWPtJA)

• toolkit/components/pdfjs/test/browser_pdfjs_alttext_telemetry.js

  • 20 of 20 failed on different tasks
    - test-linux2404-64/opt-mochitest-browser-chrome-spi-nw-1 (OncaRsPjQR-YxsxW_tePMw)
    - test-windows11-64-24h2/debug-mochitest-browser-chrome-1 (NDRg5TGyT3-U7Ggaoc0Dfg)
    - test-windows11-64-24h2/debug-mochitest-browser-chrome-spi-nw-1 (Al3AcfaeQb6D9_iCkGh_Gg)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (TBG8CTZ6SYiWQYhU8kODRA)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (cJTxSc1aQ2SldZO9KwFafA)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (HF0nMuDIQFyTLsEiViBP0g)
    - test-windows11-32-24h2/debug-mochitest-browser-chrome-1 (WN5RIWhYT2iAr_AqIWPtJA)
    - test-linux2404-64/opt-mochitest-browser-chrome-swr-1 (MvE8jdeORm-u0axCCsnFWA)
    - test-linux2404-64/opt-mochitest-browser-chrome-swr-a11y-checks-1 (FLnw3QkaQbyw8zAQ0zcypQ)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (VxmCqHypSvKaerP1kLgyBg)
    - test-windows11-64-24h2/opt-mochitest-browser-chrome-msix-1 (V5OnqOUyRAKglHcAzFALcQ)
    - test-windows11-64-24h2/opt-mochitest-browser-chrome-spi-nw-1 (A71sNR0zTM2EyH-UPmoreA)
    - test-linux2404-64/debug-mochitest-browser-chrome-swr-1 (XjCBYVRFT4KDlFb9mqQFbA)
    - test-windows11-64-24h2/opt-mochitest-browser-chrome-1 (LpsBxZumSSKLcVbvTbBQsQ)
    - test-linux2404-64/debug-mochitest-browser-chrome-spi-nw-1 (UBcLTXYCSvGu1moMC_5gjg)
    - test-windows11-32-24h2/opt-mochitest-browser-chrome-1 (SneDbRcpQO2R9SEBZyoL_w)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (fry8VfEgSWukKtnoA622PA)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (RzAQIErEROGG-28-plKz0w)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (HEJ4Ok6eTVmyB1fY-28tew)
    - test-windows11-64-24h2/debug-mochitest-browser-chrome-msix-1 (NErHYRceTxyU4gbnFRQiMg)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Calixte Denizet (:calixte)]

Superseded by bug 1976262.