1976952 - Taskbar Tabs page action ignores changes to pref after startup

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Duncan McIntosh [:dmcintosh]]

Currently, the Taskbar Tabs page action only shows if Taskbar Tabs is enabled at startup, and will keep showing (modulo fixes in bug 1966623) after disabling it until the browser is restarted. I'd expect it to appear if the pref is set, and not show if it isn't.

The current behaviour might be confusing to users who enable it in about:config, since they might not think to restart their browser. (It's also annoying if I have to run ./mach run twice! :) )

Comment 1

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 1976952 - Change Taskbar Tabs page action visibility as the pref changes. r=nrishel!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2feb4870812c
https://hg.mozilla.org/integration/autoland/rev/5e8697e1317b
Change Taskbar Tabs page action visibility as the pref changes. r=nrishel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45d92f527b92
https://hg.mozilla.org/integration/autoland/rev/c21ead163a7e
Revert "Bug 1976952 - Change Taskbar Tabs page action visibility as the pref changes. r=nrishel" for causing bc failures on browser_search_telemetry_new_window.js

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing multiple bc failures

Backout link

Push with failures

Failure log browser_search_telemetry_new_window.js
Failure log browser_uriFixupIntegration.js
Failure log browser_feature_callout_in_chrome.js
Failure log browser_fullscreen_warning.js
Failure log browser_cross_origin_isolated_reduce_time_precision.js
Failure log browser_aboutNewTab_bookmarksToolbarPrefs.js
Failure log /browser_protectionsUI_categories.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/006285eaef04
https://hg.mozilla.org/integration/autoland/rev/e0f71d89771e
Change Taskbar Tabs page action visibility as the pref changes. r=nrishel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f0d3dede48c
https://hg.mozilla.org/integration/autoland/rev/f671b48a9a86
Revert "Bug 1976952 - Change Taskbar Tabs page action visibility as the pref changes. r=nrishel" for causing failures at browser_preferences_usage.js.

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_preferences_usage.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/f671b48a9a86ad7257be1bd17c2ea353595b26d2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e0f71d89771e012c57744d938e5ee2168c127962&selectedTaskRun=H_c6Z_8bQV2HhbHYCUJirg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=518236282&repo=autoland&lineNumber=2977

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02ff1d990204
https://hg.mozilla.org/integration/autoland/rev/111b3bbe0282
Change Taskbar Tabs page action visibility as the pref changes. r=nrishel

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/111b3bbe0282