1977019 - Re-enable hw video decoding test

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Bug 1972583 incorrect disabled the hw decoding test, making us not being able to detect the scenario of fail to perform hardware decoding. With re-enabling the test and making the media-gpu` to tier1 should prevent hardware decoding from breaking again.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1977019 - part1 : re-enable hw video decoding testing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/158474bdc0cf
https://hg.mozilla.org/integration/autoland/rev/a1e7335d3222
re-enable hw video decoding testing. r=media-playback-reviewers,jolin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/617241e57031
https://hg.mozilla.org/integration/autoland/rev/5ad1f0c58c82
Revert "Bug 1977019 - re-enable hw video decoding testing. r=media-playback-reviewers,jolin" for causing win mda failures on test_hw_video_decoding.html

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing win mda failures on test_hw_video_decoding.html

Push with failures

Failure log

Backout link

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1977019 - part2 : re-initialize ffvpx as well in order to get udpdated hardware decoding support.

During the initial initialization of ffvpx, the gfx variable might not be
properly configured, leading to inaccurate hardware support detection.

Therefore, we should re-initialize it again when the gfx var is updated.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1977019 - part3 : remove av1.mp4 from hw decoding test.

The file cannot be hardware decoded due to an ffmpeg error [1], and it was
mistakenly decoded by a software decoder, which is no longer permitted following
bug 1974117. Consequently, it is necessary to exclude this file from the
hardware decoding test.

[1] https://searchfox.org/mozilla-central/rev/c329cccde3e1e6f5d71d87c62b3db7e9f5fecb3c/media/ffvpx/libavcodec/dxva2_av1.c#307-309

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d80b82051a30
https://hg.mozilla.org/integration/autoland/rev/16cde56bee87
part1 : re-enable hw video decoding testing. r=media-playback-reviewers,jolin
https://github.com/mozilla-firefox/firefox/commit/8f1e37e36b5f
https://hg.mozilla.org/integration/autoland/rev/e063e24b7d08
part2 : re-initialize ffvpx as well in order to get udpdated hardware decoding support. r=media-playback-reviewers,padenot
https://github.com/mozilla-firefox/firefox/commit/a8c90210de31
https://hg.mozilla.org/integration/autoland/rev/c4043c258b01
part3 : remove av1.mp4 from hw decoding test. r=media-playback-reviewers,padenot

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/16cde56bee87
https://hg.mozilla.org/mozilla-central/rev/e063e24b7d08
https://hg.mozilla.org/mozilla-central/rev/c4043c258b01