1977066 - Strict ETP features list missing cryptominers

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[jscher2000]

Bug 1956556 changed the feature string for cryptomining protection from "cm" to "cryptoTP" in various files, but one file was overlooked: the privacy.js file that configures the lists shown on the Settings page.

This affects the Strict mode list because the rulesArray for Strict mode is built from the value of browser.contentblocking.features.strict, which uses the new string. Ref. https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.js#1403

On the other hand, the Standard mode rulesArray is built using the old string:

        rulesArray.push(
          defaults.getBoolPref(
            "privacy.trackingprotection.cryptomining.enabled"
          )
            ? "cm"
            : "-cm"
        );

https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.js#1469

Then irrespective of source, the rulesArray is parsed using the old string, which causes the miss for the Strict mode list:

          case "cm":
            document.querySelector(selector + " .cryptominers-option").hidden =
              false;
            break;
          case "-cm":
            document.querySelector(selector + " .cryptominers-option").hidden =
              true;
            break;

https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.js#1548

This discrepancy was identified as a source of alarm by a Redditor: https://old.reddit.com/r/firefox/comments/1ly588i/no_mention_of_cryptominers_in_strict_tracking/

Seems that privacy.js needs to be updated to use the new string.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1956556

:wwen, since you are the author of the regressor, bug 1956556, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[William Wen (:wwen)]

Attachment: Bug 1977066 - Change missed "cm" strings to "cryptoTP". r=#anti-tracking-reviewers!

Comment 3

[Pascal Chevrel:pascalc]

Mark, could that be in our planned dot release? Thanks

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1956556

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c02b677b2cfa
https://hg.mozilla.org/integration/autoland/rev/2db66ca72576
Change missed "cm" strings to "cryptoTP". r=anti-tracking-reviewers,webdriver-reviewers,timhuang

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2db66ca72576

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:wwen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Tim Huang[:timhuang] [PTO 1/31 ~ 2/9]]

Attachment: Bug 1977066 - Change missed "cm" strings to "cryptoTP". r=#anti-tracking-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D257271

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: The crytominer blocking won't be configured properly if users changes ETP settings
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: The change is small.
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/76cc796eca07
https://hg.mozilla.org/releases/mozilla-beta/rev/a5221bf5b895

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please add Release and ESR140 requests also when you get a chance.

Comment 12

[Tim Huang[:timhuang] [PTO 1/31 ~ 2/9]]

Attachment: Bug 1977066 - Change missed "cm" strings to "cryptoTP". r=#anti-tracking-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D257271

Comment 13

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: The crytominer blocking won't be configured properly if users changes ETP settings
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: low
• Explanation of risk level: The change is small.
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Tim Huang[:timhuang] [PTO 1/31 ~ 2/9]]

Attachment: Bug 1977066 - Change missed "cm" strings to "cryptoTP". r=#anti-tracking-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D257271

Comment 15

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: The crytominer blocking won't be configured properly if users changes ETP settings
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Low
• Explanation of risk level: The change is small.
• String changes made/needed: None
• Is Android affected?: no

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/c0c28bdc71e5

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4f5bf8fcacb1
https://hg.mozilla.org/releases/mozilla-release/rev/0eb01447f8db

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI this was fixed upstream on Puppeteer side via https://github.com/puppeteer/puppeteer/pull/14028.

Comment 19

[Ciprian Georgiu, Desktop QA]

I've reproduced this issue using an affected Nightly build (2025-07-12) on Win 11.

The issue is verified as fixed on the fixed builds: 143.0a1, 142.0, 141.0.3 and 140.2.0 Esr.