1977191 - Land Glean v65.0.0 in m-c

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

There's a bunch of things going into the next release, thus a major version bump.
We'll need to coordinate that again.

Comment 1

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

Attachment: Bug 1977191 - Update to Glean v65.0.1 r?TravisLong

This also upgrades to rkv 0.20
The required code changes for FOG are in the followup patch.

Comment 2

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

Attachment: Bug 1977191 - Adopt new Glean APIs in the FOG wrappers r?TravisLong

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3a73ceedb25
https://hg.mozilla.org/integration/autoland/rev/d3268fb3ac2f
Update to Glean v65.0.0 r=TravisLong,supply-chain-reviewers,mach-reviewers
https://github.com/mozilla-firefox/firefox/commit/dd277a55a9d3
https://hg.mozilla.org/integration/autoland/rev/981c097b8641
Adopt new Glean APIs in the FOG wrappers r=TravisLong

Comment 4

[Iulian Moraru]

Revert for causing multiple fenix build failures.

• Push with failures

• Failure log example 1

• Failure log example 2

• Backout link

Comment 5

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

gnaaah, yes, example 2 I have a fix for. looking into what's going on in example 1 now.

Comment 6

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

the baseline profile failures (example 1 from above) seem to be bug 1983007

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b37cf7344fb8
https://hg.mozilla.org/integration/autoland/rev/d12abefa4a31
Update to Glean v65.0.0 r=TravisLong,supply-chain-reviewers,mach-reviewers
https://github.com/mozilla-firefox/firefox/commit/3dc8ee1e895f
https://hg.mozilla.org/integration/autoland/rev/551a1db0191b
Adopt new Glean APIs in the FOG wrappers r=TravisLong

Comment 8

[amarc]

Backed out for causing fenix bpgo failures

• Backout link
• Push with failures
• Failure Log

Comment 9

[Aaron Train [:aaronmt]]

This update also triggered various instrumentation crashes in Focus all with the stack

kotlin.UninitializedPropertyAccessException: lateinit property inner has not been initialized
	at mozilla.telemetry.glean.private.StringMetricType.getInner(StringMetricType.kt:22)
	at mozilla.telemetry.glean.private.StringMetricType.set$lambda$1(StringMetricType.kt:41)
	at mozilla.telemetry.glean.private.StringMetricType.$r8$lambda$mnD_YlAgg7ATArAcV8kulhdLmaI(Unknown Source:0)
	at mozilla.telemetry.glean.private.StringMetricType$$ExternalSyntheticLambda1.invoke(D8$$SyntheticClass:0)
	at mozilla.telemetry.glean.Dispatchers$DelayedTaskQueue.launch(Dispatchers.kt:69)
	at mozilla.telemetry.glean.private.StringMetricType.set(StringMetricType.kt:40)
	at org.mozilla.focus.telemetry.GleanMetricsService$collectPrefMetricsAsync$1.invokeSuspend(GleanMetricsService.kt:179)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@2673e9c, Dispatchers.IO]

https://treeherder.mozilla.org/logviewer?job_id=523216246&repo=autoland&task=beDqrc-jQXuzgKHiV7G0wg.0

Testable on Try via --preset firefox-android

Comment 10

[amarc]

(In reply to amarc from comment #8)

Backed out for causing fenix bpgo failures

• Backout link
• Push with failures
• Failure Log

Also these ui-test failures

Comment 11

[Jan-Erik Rediger [:janerik] (Away until 2026-01-05)]

(In reply to Aaron Train [:aaronmt] from comment #9)

This update also triggered various instrumentation crashes in Focus all with the stack

kotlin.UninitializedPropertyAccessException: lateinit property inner has not been initialized
	at mozilla.telemetry.glean.private.StringMetricType.getInner(StringMetricType.kt:22)
	at mozilla.telemetry.glean.private.StringMetricType.set$lambda$1(StringMetricType.kt:41)
	at mozilla.telemetry.glean.private.StringMetricType.$r8$lambda$mnD_YlAgg7ATArAcV8kulhdLmaI(Unknown Source:0)
	at mozilla.telemetry.glean.private.StringMetricType$$ExternalSyntheticLambda1.invoke(D8$$SyntheticClass:0)
	at mozilla.telemetry.glean.Dispatchers$DelayedTaskQueue.launch(Dispatchers.kt:69)
	at mozilla.telemetry.glean.private.StringMetricType.set(StringMetricType.kt:40)
	at org.mozilla.focus.telemetry.GleanMetricsService$collectPrefMetricsAsync$1.invokeSuspend(GleanMetricsService.kt:179)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@2673e9c, Dispatchers.IO]

https://treeherder.mozilla.org/logviewer?job_id=523216246&repo=autoland&task=beDqrc-jQXuzgKHiV7G0wg.0

Testable on Try via --preset firefox-android

Yup, they seem to be coming down to the same issue. A bit surprised by that, because at least in one instance the code is older than this update (and my testing before didn't unconver these either)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/57c3781415f8
https://hg.mozilla.org/integration/autoland/rev/8c455066bc05
Update to Glean v65.0.1 r=TravisLong,supply-chain-reviewers,mach-reviewers
https://github.com/mozilla-firefox/firefox/commit/4ae8d53abbdd
https://hg.mozilla.org/integration/autoland/rev/18363d3a3f30
Adopt new Glean APIs in the FOG wrappers r=TravisLong

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8c455066bc05
https://hg.mozilla.org/mozilla-central/rev/18363d3a3f30