1977257 - [wpt-sync] Sync PR 53753 - Default to empty `value` for named cookies in cookieStore.delete

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53753 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53753
Details from upstream follow.

anushamuley <[e-mail]> wrote:

Default to empty value for named cookies in cookieStore.delete

Based on https://github.com/WICG/cookie-store/pull/261 we should only
use an implementation defined string as a cookie's value when we are
deleting a nameless cookie. Otherwise cookies with a name of the
maximum supported name and value size would not be able to be
deleted by this API. Also add a WPT to check for this behavior.

Change-Id: I09ab4af872f34695c635c1342852def183fb3070
Bug: 427258226, 431030814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6604039
Commit-Queue: Aaron Selya \<[e-mail]>
Reviewed-by: Aaron Selya \<[e-mail]>
Reviewed-by: Dylan Cutler \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1486511}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=95472d4b9ee3b7aacedccbd990e12ac11e0e92a5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=90faed17f6f5401df7608bfe60569d80906650a1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 17 subtests

Status Summary

Firefox

OK : 2
PASS: 34

Chrome

OK : 2
PASS: 29
FAIL: 5

Safari

OK : 2
PASS: 1
FAIL: 33

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /cookie-store/cookieStore_delete_arguments.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
• /cookie-store/cookieStore_delete_arguments.https.any.serviceworker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)

Tests Disabled in Gecko Infrastructure

• /cookie-store/cookieStore_delete_arguments.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
• /cookie-store/cookieStore_delete_arguments.https.any.serviceworker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f5a945435e4
https://hg.mozilla.org/integration/autoland/rev/ecbecca67f8b
[wpt PR 53753] - Default to empty `value` for named cookies in cookieStore.delete, a=testonly

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ecbecca67f8b