1977304 - Don't use local path file on Android 11+

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Makoto Kato [:m_kato]]

https://developer.android.com/reference/android/provider/MediaStore.MediaColumns.html#DATA

From Android 11 onwards, this column is read-only for apps that target R and higher. On those devices, when creating or updating a uri, this column's value is not accepted. Instead, to update the filesystem location of a file, use the values of the DISPLAY_NAME and RELATIVE_PATH columns.

Though direct file operations are supported, ContentResolver.openFileDescriptor(Uri, String) API is recommended for better performance.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1977304 - Part 1. Don't use local path file on Android 11+. r=#geckoview-reviewers

From Android 11, the local path from file may not be accessible. So if
11 or later, we should always use the content URI when using folder picker.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1977304 - Part 2. Close input stream immediately. r=#geckoview-reviewers

After we use input stream for content:// uri, we should close immediately to
release object soon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/75f7f21c0e43
https://hg.mozilla.org/integration/autoland/rev/dd82e985dae0
Part 1. Don't use local path file on Android 11+. r=geckoview-reviewers,ohall
https://github.com/mozilla-firefox/firefox/commit/26d18a67b9a6
https://hg.mozilla.org/integration/autoland/rev/cc7810f86e80
Part 2. Close input stream immediately. r=geckoview-reviewers,ohall

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/dd82e985dae0
https://hg.mozilla.org/mozilla-central/rev/cc7810f86e80

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9500840 [details]
Bug 1977304 - Part 1. Don't use local path file on Android 11+. r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: When using Android 11 or later, user cannot upload files using folder picker on www.dropbox.com.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low. This code only runs on Android 11 or later.

If Android 11, we use Android API to read file instead of reading local file by file path. Android 11 or later doesn't allow to access local file directly under user data folders.

• String changes made/needed: No
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9500840 [details]
Bug 1977304 - Part 1. Don't use local path file on Android 11+. r=#geckoview-reviewers

Approved for 142.0b5

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a2c9a53d4376
https://hg.mozilla.org/releases/mozilla-beta/rev/addbd8907742
https://github.com/mozilla-firefox/firefox/commit/98d71f010414
https://hg.mozilla.org/releases/mozilla-beta/rev/3e4c35fb0162