Closed Bug 1977447 Opened 5 months ago Closed 2 months ago

Expand address feature gate to use supported countries and not language tags

Categories

(Firefox for Android :: Autofill, task)

All
Android
task

Tracking

()

RESOLVED FIXED
146 Branch
Tracking Status
firefox146 --- fixed

People

(Reporter: segun, Assigned: boek)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] [group1])

Attachments

(1 file, 1 obsolete file)

Right now, we use language tags to feature-gate the address autofill feature. However, as part of the expansion to support more countries/regions, we need to expand our feature-gate to use countries/regions (e.g US as opposed to language tag en-US) because:

  1. It brings us to par with iOS. iOS uses regions for this, and not combination of region and device language like we currently do.
  2. It solves for varying combinations of locales that may be difficult to maintain. For example, it is possible to select en-DE as a combination, and this means your phone language is English, but your region/country is Germany. If we support only de-DE, then we lock out other users that have their regions set to Germany, but phones set to other languages.
Depends on: 1978557
Blocks: 1990854
Assignee: nobody → jboek
Status: NEW → ASSIGNED

We're adding support for all regions, so there is no longer a reason to gate to a specific subset.

Summary: Expand address feature gate to use supported countries and not language tags → Enable address autofill for all locales
No longer blocks: 1990854
Blocks: 1978557
No longer depends on: 1978557
Attachment #9522116 - Attachment is obsolete: true

To reach parity with desktop we are going to enable address autofill in the same regions that desktop has them enabled for.

Summary: Enable address autofill for all locales → Expand support for address autofill to match desktop
Summary: Expand support for address autofill to match desktop → Expand address feature gate to use supported countries and not language tags
Pushed by jboek@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f7a39edacec0 https://hg.mozilla.org/integration/autoland/rev/d73b3fab0fc4 Gate the address feature based on just the country r=android-reviewers,matt-tighe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: