Closed
Bug 1977447
Opened 5 months ago
Closed 2 months ago
Expand address feature gate to use supported countries and not language tags
Categories
(Firefox for Android :: Autofill, task)
Tracking
()
RESOLVED
FIXED
146 Branch
| Tracking | Status | |
|---|---|---|
| firefox146 | --- | fixed |
People
(Reporter: segun, Assigned: boek)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group1])
Attachments
(1 file, 1 obsolete file)
Right now, we use language tags to feature-gate the address autofill feature. However, as part of the expansion to support more countries/regions, we need to expand our feature-gate to use countries/regions (e.g US as opposed to language tag en-US) because:
- It brings us to par with iOS. iOS uses regions for this, and not combination of region and device language like we currently do.
- It solves for varying combinations of locales that may be difficult to maintain. For example, it is possible to select
en-DEas a combination, and this means your phone language is English, but your region/country is Germany. If we support onlyde-DE, then we lock out other users that have their regions set to Germany, but phones set to other languages.
Updated•5 months ago
|
| Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Assignee: nobody → jboek
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•2 months ago
•
|
||
We're adding support for all regions, so there is no longer a reason to gate to a specific subset.
Summary: Expand address feature gate to use supported countries and not language tags → Enable address autofill for all locales
| Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
Attachment #9522116 -
Attachment is obsolete: true
| Assignee | ||
Comment 3•2 months ago
|
||
To reach parity with desktop we are going to enable address autofill in the same regions that desktop has them enabled for.
Summary: Enable address autofill for all locales → Expand support for address autofill to match desktop
| Assignee | ||
Updated•2 months ago
|
Summary: Expand support for address autofill to match desktop → Expand address feature gate to use supported countries and not language tags
| Assignee | ||
Comment 4•2 months ago
|
||
Pushed by jboek@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f7a39edacec0
https://hg.mozilla.org/integration/autoland/rev/d73b3fab0fc4
Gate the address feature based on just the country r=android-reviewers,matt-tighe
Comment 6•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox146:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•