Closed Bug 1977458 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 53771 - [animation-trigger] Update animation-trigger parsing

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53771 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53771
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

[animation-trigger] Update animation-trigger parsing

The updated plan for animation-trigger related properties is to move
properties specific to types of triggers to separate CSS property
namespaces.

Under this new format, animation-trigger simply specifies a list of dash
idents which are matched against names declared by the type-specific
trigger properties.

Here is an example of how the property will be used:

  timeline-trigger: --trigger view() repeat contain 0% contain 100%;
}

  animation: animation1;
  animation-trigger: --trigger;
}

\<div id="scroller">
  \<div id="viewtarget1">\</div>
  \<div>Lots of other content.\</div>
  \<div id="viewtarget2">\</div>
\</div>

\<div id="animatable">\</div>

In this example, scrolling either viewtarget into view will play the
animation. More examples can be seen at [2]

The tests in animation-trigger-parsing.tentative.html have been modeled
to follow the precedent set by anchor-name.

[1] https://github.com/w3c/csswg-drafts/issues/12336 [2]
https://github.com/explainers-by-googlers/scroll-triggered-animations/blob/main/CSS_PROPERTIES.md

Change-Id: I532e5c65feee8676ed56b62cd178c6efa13afe81
Reviewed-on: https://chromium-review.googlesource.com/6717917
WPT-Export-Revision: 8016773bb1e6a1b18b18a40fcccfaa1b3451ebf6

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 53 subtests

Status Summary

Firefox

OK : 1
PASS: 15
FAIL: 38

Chrome

OK : 1
PASS: 17
FAIL: 36

Safari

OK : 1
PASS: 15
FAIL: 38

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/animation-trigger/parsing/animation-trigger-parsing.tentative.html [wpt.fyi]
    • e.style['animation-trigger'] = "initial" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['animation-trigger'] = "inherit" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['animation-trigger'] = "unset" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['animation-trigger'] = "revert" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
    • e.style['animation-trigger'] = "none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = " --abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--aBc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--foo, --bar" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--bar, --foo" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "none, none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--a, none, --b" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--abc --bcd, --cde --def" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--abc --abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = " --abc --abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = " --abc --bcd" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--aBc --abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--aBc --abc --aBc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--aBc, --aBc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "--abc --bcd, --abc --bcd" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-trigger'] = "---abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value 'none': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--abc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value ' --abc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--aBc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--foo, --bar': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--bar, --foo': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value 'none, none': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--abc --bcd, --cde --def': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--abc --abc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value ' --abc --abc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value ' --abc --bcd': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--aBc --abc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--aBc --abc --aBc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--aBc, --aBc': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--abc --bcd, --abc --bcd': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '--a, none, --b': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property animation-trigger value '---abc': FAIL (Chrome: FAIL, Safari: FAIL)

https://hg.mozilla.org/mozilla-central/rev/925f21e0787d
https://hg.mozilla.org/mozilla-central/rev/249211fab18c

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.