1977550 - ElementStyle#_hasUpdatedCSSVariable can be slow when there is a lot of CSS variables

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1903632, I found that _hasUpdatedCSSVariable is taking half a second on https://hh.ru/search/resume?area=85 (https://share.firefox.dev/3VQSGdo).
That's because we're looping through a Set that is probably quite large here https://searchfox.org/mozilla-central/rev/74518d4f6979b088e28405ba7e6238f4707639cf/devtools/client/inspector/rules/models/element-style.js#507-515

_hasUpdatedCSSVariable(declaration, variableNamesSet) {
  for (const variableName of variableNamesSet) {
    if (declaration.hasCSSVariable(variableName)) {
      return true;
    }
  }

  return false;
}

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1977550 - [devtools] Use Set#isDisjointFrom in ElementStyle#_hasUpdatedCssVariable. r=#devtools.

This is way faster than iterating through the Set.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f30686cab907
https://hg.mozilla.org/integration/autoland/rev/e144109f611d
[devtools] Use Set#isDisjointFrom in ElementStyle#_hasUpdatedCssVariable. r=devtools-reviewers,ochameau.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e144109f611d