1977559 - When searching open tabs via % and there's a contextual search engine, urlbar-results incorrectly has actionmode attribute set

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Dão Gottwald [:dao]]

STR: have a bunch of tabs, open reddit, enter % in the address bar.

The .urlbar-results element now has the actionmode attribute set -- incorrectly so I believe, and it seems this is the root cause of bug 1976031.

The actionmode attribute set is not set when either entering another string, or when entering % while not on a page with a contextual search engine.

Dale, do you agree this seems broken?

Comment 1

[Dale Harvey (:daleharvey)]

Yup looks like a bug to me, the other modes have temporary modes which are entered as soon as the prefix goes in (although kinda expected the chicklet to show then), but actions mode doesnt, we only want to set that when we are fully in actionmode

Comment 2

[Chris Bellini (:cbellini)]

:dale, would you be able to set the priority and severity for this is, and provide an overview of what the user-facing (or other) impacts of this bug are?

Comment 3

[Dale Harvey (:daleharvey)]

This is relatively low priority as Dao fixed the user facing side of the issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1976031, which leaves this as a refactoring / correctness issue, its possible for it to lead to user facing issues in future but dont see any more at the moment