Closed Bug 1977627 Opened 1 month ago Closed 1 month ago

Increase position classes for sections with a high number of cards

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

VERIFIED FIXED
142 Branch
Tracking Status
firefox141 --- fixed
firefox142 --- verified

People

(Reporter: nbarrett, Assigned: nbarrett)

Details

Attachments

(2 files)

Currently, we only have rules for order in the section grid up to six items, we should increase it to whatever highest amount we believe would be in a section

Summary: Allow high position CSS for section layout → Increase position classes for sections with a high number of cards
Assignee: nobody → nbarrett
Status: NEW → ASSIGNED
Pushed by nbarrett@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fdfe98778d65 https://hg.mozilla.org/integration/autoland/rev/63b8d2e8c577 Increase position classes for sections with a high number of cards r=home-newtab-reviewers,maxx
Attachment #9501026 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: This would impact the timeline for sections experimental layout
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D257519
  • Risk associated with taking this patch: Low
  • Explanation of risk level: CSS only, applies to a feature that is behind a pref
  • String changes made/needed: No
  • Is Android affected?: no
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
QA Whiteboard: [qa-triage-done-c142/b141]

I have verified this issue using the latest Firefox Nightly 142.0a1 (Build ID: 20250716214535) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.

  • After following the steps outlined in the test plan, I confirm the following:
    • The layout of the first section is displayed correctly, and the cards are properly aligned.
    • I didn’t encounter any unexpected gaps, overflow, or layout shifting in the default view or while resizing the browser across different screen sizes.
Status: RESOLVED → VERIFIED

Comment on attachment 9501026 [details]
Bug 1977627 - Increase position classes for sections with a high number of cards r=#home-newtab-reviewers

Changing this request for uplift from beta to release, since 142 is now in beta.

Attachment #9501026 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Attachment #9501026 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: