Closed
Bug 1977627
Opened 1 month ago
Closed 1 month ago
Increase position classes for sections with a high number of cards
Categories
(Firefox :: New Tab Page, task)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
142 Branch
People
(Reporter: nbarrett, Assigned: nbarrett)
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-release+
|
Details | Review |
Currently, we only have rules for order
in the section grid up to six items, we should increase it to whatever highest amount we believe would be in a section
Assignee | ||
Updated•1 month ago
|
Summary: Allow high position CSS for section layout → Increase position classes for sections with a high number of cards
Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Assignee: nobody → nbarrett
Status: NEW → ASSIGNED
Pushed by nbarrett@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/fdfe98778d65
https://hg.mozilla.org/integration/autoland/rev/63b8d2e8c577
Increase position classes for sections with a high number of cards r=home-newtab-reviewers,maxx
Comment 3•1 month ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D257519
Updated•1 month ago
|
Attachment #9501026 -
Flags: approval-mozilla-beta?
Comment 4•1 month ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: This would impact the timeline for sections experimental layout
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D257519
- Risk associated with taking this patch: Low
- Explanation of risk level: CSS only, applies to a feature that is behind a pref
- String changes made/needed: No
- Is Android affected?: no
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c142/b141]
Comment 6•1 month ago
•
|
||
I have verified this issue using the latest Firefox Nightly 142.0a1 (Build ID: 20250716214535) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.
- After following the steps outlined in the test plan, I confirm the following:
- The layout of the first section is displayed correctly, and the cards are properly aligned.
- I didn’t encounter any unexpected gaps, overflow, or layout shifting in the default view or while resizing the browser across different screen sizes.
Status: RESOLVED → VERIFIED
Comment 7•28 days ago
|
||
Comment on attachment 9501026 [details]
Bug 1977627 - Increase position classes for sections with a high number of cards r=#home-newtab-reviewers
Changing this request for uplift from beta to release, since 142 is now in beta.
Attachment #9501026 -
Flags: approval-mozilla-beta? → approval-mozilla-release?
Updated•19 days ago
|
Attachment #9501026 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•19 days ago
|
status-firefox141:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•