1977669 - Firefox Profiler UI timeline labels no longer centered vertically

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Attachment: screenshot

Example: https://share.firefox.dev/4kGW2c0

The labels in the <button> at the left of the timeline were vertically centered in the past, but aren't anymore. Removing visibility:hidden makes the labels centered again.
In Chrome they are centered even with visibility:hidden.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Removing visibility:hidden makes the labels centered again.

wat.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1873301

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Oh, overflow: hidden, not visibility: hidden :)

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1977669 - Scrolled button frames should still be centered and baseline aligned to the content box. r=#layout

Avoid the scroll container special-case for inline-blocks for them, and
allow a ::-moz-scrolled-content button box to still center-align its
contents.

Comment 5

[Markus Stange [:mstange]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Oh, overflow: hidden, not visibility: hidden :)

Hah, oops! I read it so many times and never noticed I had written the wrong property.

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: screenshot of similar bug on Amazon/Whole Foods UI

FWIW I confirmed locally that this patch fixes a version of the same bug on Amazon.com when shopping for Whole Foods Market grocery-pickup (see screenshot). They have some dropdown-menu-widgets which they represent (when closed at least) as a <button> with overflow:hidden, baseline-aligned with an i element with a downarrow-graphic as its background-image.

In Firefox Nightly and in a build from current git tip: the button label text is misaligned as shown in this screenshot. But I confirmed that it's fixed in a build with this patch attached.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e5b2a9fd233
https://hg.mozilla.org/integration/autoland/rev/5e36dc444954
Scrolled button frames should still be centered and baseline aligned to the content box. r=dholbert

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c09786b7a55b
https://hg.mozilla.org/integration/autoland/rev/fdcb70fb304a
Revert "Bug 1977669 - Scrolled button frames should still be centered and baseline aligned to the content box. r=dholbert" for causing wpt failures in anonymous-button-content-box.html.

Comment 9

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures in anonymous-button-content-box.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /html/rendering/widgets/button-layout/anonymous-button-content-box.html | Testing http://web-platform.test:8000/html/rendering/widgets/button-layout/anonymous-button-content-box.html == http://web-platform.test:8000/html/rendering/widgets/button-layout/anonymous-button-content-box-ref.html

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24ea549f78df
https://hg.mozilla.org/integration/autoland/rev/119fc6ab76b6
Scrolled button frames should still be centered and baseline aligned to the content box. r=dholbert

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53830 for changes under testing/web-platform/tests

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/119fc6ab76b6

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2025-07-16 Firefox Nightly build on Windows 10, with the example and steps from Comment 0.
Verified as fixed on Firefox Nightly 143.0a1 and Firefox 142.0b5 on Windows 10, Ubuntu 22, macOS 13.