Open
Bug 1977695
Opened 1 year ago
Updated 7 months ago
Enable Homepage as a New Tab for Nightly
Categories
(Firefox for Android :: Homepage, task, P3)
Tracking
()
ASSIGNED
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group5])
Attachments
(3 files)
Enable Homepage as a New Tab in the Nightly/Debug channel starting on 143. This will not ride the trains into the general release as part of the task. We are enabling the feature only for the Nightly audience in order to begin QA of the feature.
| Assignee | ||
Updated•1 year ago
|
Whiteboard: [fxdroid] [group5]
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
- Enables Homepage as a New Tab for Debug and Nightly builds starting in 143.
Updated•1 year ago
|
Attachment #9501099 -
Attachment description: Bug 1977695 - Enable Homepage as a New Tab for Debug and Nightly build → Bug 1977695 - Part 1: Enable Homepage as a New Tab for Debug and Nightly build
| Assignee | ||
Comment 2•1 year ago
|
||
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f971c6a8c456
https://hg.mozilla.org/integration/autoland/rev/335e5e2e1ed0
Part 1: Enable Homepage as a New Tab for Debug and Nightly build r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/071099f42ee6
https://hg.mozilla.org/integration/autoland/rev/37278670d273
Part 2: Disable Homepage as a New Tab by default in UI tests r=android-reviewers,aaronmt,jonalmeida,ajoltan
Pushed by imoraru@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/4f568601bf02
https://hg.mozilla.org/integration/autoland/rev/ed2fc7f0f38c
Revert "Bug 1977695 - Part 2: Disable Homepage as a New Tab by default in UI tests r=android-reviewers,aaronmt,jonalmeida,ajoltan" for causing fenix failures.
Comment 5•1 year ago
|
||
Revert for causing fenix failures.
[task 2025-07-24T01:04:03.614+00:00] RunTests
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] Smart Flank cache hit: 0% (0 / 6)
[task 2025-07-24T01:04:03.614+00:00] Shard times: 120s, 120s, 120s, 120s, 120s, 120s
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] 6 tests / 6 shards
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] 1 matrix ids created in 0m 4s
[task 2025-07-24T01:04:03.614+00:00] Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/fenix_test_artifacts/2025-07-24_00-59-50.390381_YAxt]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] Matrices webLink
[task 2025-07-24T01:04:03.614+00:00] matrix-o7ohiuh5nylwa https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/6453747204976779479/details
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] 3m 53s matrix-o7ohiuh5nylwa FINISHED
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] CostReport
[task 2025-07-24T01:04:03.614+00:00] Physical devices
[task 2025-07-24T01:04:03.614+00:00] $0.67 for 8m
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] MatrixResultsReport
[task 2025-07-24T01:04:03.614+00:00] 0 / 1 (0.00%)
[task 2025-07-24T01:04:03.614+00:00] 1 matrices failed
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] ┌─────────┬──────────────────────┬──────────────────────┬───────────────────┬─────────────────────────┬───────────────────────────────┐
[task 2025-07-24T01:04:03.614+00:00] │ OUTCOME │ MATRIX ID │ APP NAME │ TEST FILE NAME │ TEST AXIS VALUE │ TEST DETAILS │
[task 2025-07-24T01:04:03.614+00:00] ├─────────┼──────────────────────┼──────────────────────┼───────────────────┼─────────────────────────┼───────────────────────────────┤
[task 2025-07-24T01:04:03.614+00:00] │ [31mfailure[0m │ matrix-o7ohiuh5nylwa │ target.arm64-v8a.apk │ target.noarch.apk │ shiba-34-en_US-portrait │ 2 test cases failed, 4 passed │
[task 2025-07-24T01:04:03.614+00:00] └─────────┴──────────────────────┴──────────────────────┴───────────────────┴─────────────────────────┴───────────────────────────────┘
[task 2025-07-24T01:04:03.614+00:00] More details are available at:
[task 2025-07-24T01:04:03.614+00:00] https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/6453747204976779479/details
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00] Matrices webLink
[task 2025-07-24T01:04:03.614+00:00] matrix-o7ohiuh5nylwa https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.80a1a071cfb2770e/matrices/6453747204976779479/details
[task 2025-07-24T01:04:03.614+00:00] Actual shard times:
[task 2025-07-24T01:04:03.614+00:00] Shard 0: Expected: 0s, Actual: 23s, Diff: 23s
[task 2025-07-24T01:04:03.614+00:00] Shard 1: Expected: 0s, Actual: 25s, Diff: 25s
[task 2025-07-24T01:04:03.614+00:00] Shard 2: Expected: 0s, Actual: 35s, Diff: 35s
[task 2025-07-24T01:04:03.614+00:00] Shard 3: Expected: 0s, Actual: 38s, Diff: 38s
[task 2025-07-24T01:04:03.614+00:00] Shard 4: Expected: 0s, Actual: 27s, Diff: 27s
[task 2025-07-24T01:04:03.614+00:00] Shard 5: Expected: 0s, Actual: 31s, Diff: 31s
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.614+00:00]
[task 2025-07-24T01:04:03.615+00:00] Command /usr/bin/java -jar /builds/worker/test-tools/flank.jar android run --config /builds/worker/checkouts/gecko/taskcluster/scripts/tests/../../../mobile/android/test_infra/flank-configs/fenix/arm64-v8a-macrobenchmark.yml --app /builds/worker/fetches/target.arm64-v8a.apk --local-result-dir /builds/worker/artifacts/results --project moz-fenix --client-details matrixLabel=autoland,geckoRev=37278670d2732bca5c7b1fab81dd91c2c704d6dd --test /builds/worker/fetches/target.noarch.apk failed with exit code 10
[task 2025-07-24T01:04:03.661+00:00] TEST-UNEXPECTED-FAIL | org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark#onboardingNone | androidx.test.uiautomator.UiObjectNotFoundException: UiSelector[TEXT=Not now]
[task 2025-07-24T01:04:03.661+00:00] at androidx.test.uiautomator.UiObject.click(UiObject.java:378)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.UiDeviceKt.completeOnboarding(UiDevice.kt:53)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboardingBenchmark$lambda$1(BaselineProfilesOnboardingBenchmark.kt:76)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.$r8$lambda$ERtkpacyNSmbI56pl8s8CTkrdno(Unknown Source:0)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark$$ExternalSyntheticLambda1.invoke(D8$$SyntheticClass:0)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt$runPhase$2$tracePath$1.invoke(MacrobenchmarkPhase.kt:139)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt$runPhase$2$tracePath$1.invoke(MacrobenchmarkPhase.kt:105)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record(PerfettoCaptureWrapper.kt:137)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record$default(PerfettoCaptureWrapper.kt:95)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt.runPhase(MacrobenchmarkPhase.kt:105)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$4.invoke(Macrobenchmark.kt:267)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$4.invoke(Macrobenchmark.kt:264)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer-VtjQ1oo(PerfettoTraceProcessor.kt:133)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:108)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:264)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:401)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:108)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.MacroBenchmarkRuleKt.measureRepeatedDefault(MacroBenchmarkRule.kt:28)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.MacroBenchmarkRuleKt.measureRepeatedDefault$default(MacroBenchmarkRule.kt:18)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboardingBenchmark(BaselineProfilesOnboardingBenchmark.kt:64)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboardingNone(BaselineProfilesOnboardingBenchmark.kt:57)
[task 2025-07-24T01:04:03.661+00:00]
[task 2025-07-24T01:04:03.661+00:00]
[task 2025-07-24T01:04:03.661+00:00] TEST-UNEXPECTED-FAIL | org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark#onboarding | androidx.test.uiautomator.UiObjectNotFoundException: UiSelector[TEXT=Not now]
[task 2025-07-24T01:04:03.661+00:00] at androidx.test.uiautomator.UiObject.click(UiObject.java:378)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.UiDeviceKt.completeOnboarding(UiDevice.kt:53)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboardingBenchmark$lambda$1(BaselineProfilesOnboardingBenchmark.kt:76)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.$r8$lambda$ERtkpacyNSmbI56pl8s8CTkrdno(Unknown Source:0)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark$$ExternalSyntheticLambda1.invoke(D8$$SyntheticClass:0)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt$runPhase$2$tracePath$1.invoke(MacrobenchmarkPhase.kt:139)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt$runPhase$2$tracePath$1.invoke(MacrobenchmarkPhase.kt:105)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record(PerfettoCaptureWrapper.kt:137)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record$default(PerfettoCaptureWrapper.kt:95)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkPhaseKt.runPhase(MacrobenchmarkPhase.kt:105)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$4.invoke(Macrobenchmark.kt:267)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$4.invoke(Macrobenchmark.kt:264)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer-VtjQ1oo(PerfettoTraceProcessor.kt:133)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:108)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:264)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:401)
[task 2025-07-24T01:04:03.661+00:00] at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:108)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.MacroBenchmarkRuleKt.measureRepeatedDefault(MacroBenchmarkRule.kt:28)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.utils.MacroBenchmarkRuleKt.measureRepeatedDefault$default(MacroBenchmarkRule.kt:18)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboardingBenchmark(BaselineProfilesOnboardingBenchmark.kt:64)
[task 2025-07-24T01:04:03.661+00:00] at org.mozilla.fenix.benchmark.BaselineProfilesOnboardingBenchmark.onboarding(BaselineProfilesOnboardingBenchmark.kt:61)
[task 2025-07-24T01:04:03.661+00:00]
<...>
Flags: needinfo?(gl)
| Assignee | ||
Comment 6•1 year ago
|
||
- When "about:home" homepage tab is added, it will attempt to load and navigate to the homepage. This happens during the app startup as part of
StartupMiddlewarewhen there are no tabs available. This can mistakenly navigate away from the first run onboarding during a fresh profile startup as the homepage is added and the binding or interceptor will receive the URL it is observing. - This fixes the benchmark failure seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1977695#c5 which is the result of navigating to the homepage after the onboarding is displayed.
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a9652dc784d0
https://hg.mozilla.org/integration/autoland/rev/19745adddb1c
Part 1: Enable Homepage as a New Tab for Debug and Nightly build r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/6a167f0b10b3
https://hg.mozilla.org/integration/autoland/rev/034e47b53f7e
Part 2: Disable Homepage as a New Tab by default in UI tests r=android-reviewers,aaronmt,jonalmeida,ajoltan
https://github.com/mozilla-firefox/firefox/commit/6d0e499ba4d7
https://hg.mozilla.org/integration/autoland/rev/7e7624a53893
Part 3: Don't navigate away from onboarding during startup when Homepage as a New Tab is enabled r=android-reviewers,jonalmeida
Pushed by smolnar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/33b982989736
https://hg.mozilla.org/integration/autoland/rev/1aa61f787abe
Revert "Bug 1977695 - Part 3: Don't navigate away from onboarding during startup when Homepage as a New Tab is enabled r=android-reviewers,jonalmeida" for causing fenix failures @ AndroidTestFenixApplication.kt
Comment 9•1 year ago
|
||
Backed out for causing fenix failures @ AndroidTestFenixApplication.kt
Backout link: https://hg.mozilla.org/integration/autoland/rev/1aa61f787abe2c5f679e288df87086d43fbaf3f7
Task :app:compileFenixNightlyAndroidTestKotlin
[task 2025-07-26T16:33:58.699+00:00] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AndroidTestFenixApplication.kt:12:37 Unresolved reference 'DebugFenixApplication'.
[task 2025-07-26T16:33:58.699+00:00] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AndroidTestFenixApplication.kt:12:37: error: Unresolved reference 'DebugFenixApplication'.
[task 2025-07-26T16:33:58.699+00:00] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AndroidTestFenixApplication.kt:14:5 'isRunningInTestEnvironment' overrides nothing.
[task 2025-07-26T16:33:58.699+00:00] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/AndroidTestFenixApplication.kt:14:5: error: 'isRunningInTestEnvironment' overrides nothing.
[task 2025-07-26T16:34:00.398+00:00]
[task 2025-07-26T16:34:00.398+00:00] > Task :components:browser-thumbnails:validateSigningDebugAndroidTest
[task 2025-07-26T16:34:00.398+00:00]
[task 2025-07-26T16:34:00.398+00:00] > Task :components:browser-thumbnails:stripDebugAndroidTestDebugSymbols
[task 2025-07-26T16:34:00.398+00:00] Unable to strip the following libraries, packaging them as they are: libandroidx.graphics.path.so. Run with --info option to learn more.
Updated•1 year ago
|
Attachment #9502794 -
Attachment description: Bug 1977695 - Part 3: Don't navigate away from onboarding during startup when Homepage as a New Tab is enabled → Bug 1977695 - Part 1: Don't navigate away from onboarding during startup when Homepage as a New Tab is enabled
Updated•1 year ago
|
Attachment #9501099 -
Attachment description: Bug 1977695 - Part 1: Enable Homepage as a New Tab for Debug and Nightly build → Bug 1977695 - Part 2: Enable Homepage as a New Tab for Debug and Nightly build
Updated•1 year ago
|
Attachment #9501314 -
Attachment description: Bug 1977695 - Part 2: Disable Homepage as a New Tab by default in UI tests → Bug 1977695 - Part 3: Disable Homepage as a New Tab by default in UI tests
| Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(gl)
Keywords: leave-open
Comment 10•1 year ago
|
||
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/dce4fb9198ec
https://hg.mozilla.org/integration/autoland/rev/a5eabcd8e176
Part 1: Don't navigate away from onboarding during startup when Homepage as a New Tab is enabled r=android-reviewers,jonalmeida
Comment 11•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Updated•1 year ago
|
Keywords: leave-open
Comment 12•1 year ago
|
||
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e33fa0d7d2b4
https://hg.mozilla.org/integration/autoland/rev/79f44dd03c95
Part 2: Enable Homepage as a New Tab for Debug and Nightly build r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/dbc22e55b824
https://hg.mozilla.org/integration/autoland/rev/5c66c67b9396
Part 3: Disable Homepage as a New Tab by default in UI tests r=android-reviewers,aaronmt,jonalmeida,ajoltan
Comment 13•1 year ago
|
||
Pushed by smolnar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1162378d2672
https://hg.mozilla.org/integration/autoland/rev/d34398f38898
Revert "Bug 1977695 - Part 3: Disable Homepage as a New Tab by default in UI tests r=android-reviewers,aaronmt,jonalmeida,ajoltan" for causing android browser-time failures
Comment 14•1 year ago
|
||
Backed out for causing android browser-time failures
Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/d34398f3889876cdcd3766561306d4e49e29ddf4
Flags: needinfo?(gl)
| Assignee | ||
Updated•7 months ago
|
Flags: needinfo?(gl)
Summary: Enable Homepage as a New Tab for Nightly 143 → Enable Homepage as a New Tab for Nightly
| Assignee | ||
Updated•7 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•