Closed
Bug 197771
Opened 21 years ago
Closed 21 years ago
[FIXr]text-align: "" treated as text-align: left
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
1.44 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
See testcase in attachment 108368 [details].
We should not be parsing that successfully if we do not support it.
|
Assignee | |
Comment 1•21 years ago
|
||
Note also the code in nsRuleNode::ComputeTextData that has:
2369 else if (eCSSUnit_String == textData.mTextAlign.GetUnit()) {
2370 NS_NOTYETIMPLEMENTED("align string");
2371 }
So we really should not be parsing it... ;)|
|
Assignee | |
Updated•21 years ago
|
Attachment #117452 -
Flags: superreview?(dbaron)
Attachment #117452 -
Flags: review?(dbaron)
Attachment #117452 -
Flags: superreview?(dbaron)
Attachment #117452 -
Flags: superreview+
Attachment #117452 -
Flags: review?(dbaron)
Attachment #117452 -
Flags: review+
|
|
Assignee | |
Updated•21 years ago
|
Summary: text-align: "" treated as text-align: left → [FIXr]text-align: "" treated as text-align: left
|
|
Assignee | |
Comment 2•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Comment 3•21 years ago
|
||
verified. bug 2212 open for text-align: <string> issue
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•