1977746 - [HDR/Windows] Play HDR video using an RGB10A2 swapchain with appropriate colorspace

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, task, P1)

Description

[Ashley Hale [:ahale]]

For all common viewing scenarios we want to convert HDR video in Rec2100PQ P010 format to Rec2100PQ in RGB10A2 pixel format, and apply appropriate color conversions (Bug 1977744) while doing so, this can be displayed as a DXGISwapChain with the appropriate SetColorspace() call to indicate it is Rec2100PQ.

Comment 1

[Ashley Hale [:ahale]]

There may be situations where we need to play video as RGBA16F (DXGI_FORMAT_R16G16B16A16_FLOAT) if it has transparency (AV1 I believe supports that?) - this also technically means it could be displayed as a surface rather than a swapchain if that is useful, surfaces can't be DXGI_FORMAT_R10G10B10A2_UNORM format but they can be DXGI_FORMAT_R16G16B16A16_FLOAT).

For now I am prototyping video using RGBA16F as it has the least considerations to deal with (e.g. we don't have to call IDXGISwapChain3::SetColorSpace1, DWM knows that RGBA16F is always scRGB).

Comment 2

[Ashley Hale [:ahale]]

Attachment: Bug 1977746 - display HDR video on Windows using RGB10A2

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/38bbd8dd7935
https://hg.mozilla.org/integration/autoland/rev/1ce82d084f8f
display HDR video on Windows using RGB10A2 r=bradwerth,gfx-reviewers,media-playback-reviewers,sotaro,alwu

Comment 4

[Ashley Hale [:ahale]]

Attachment: Bug 1977746 - fix layout.css.video-dynamic-range.allows-high pref initial value on Windows for early-beta/nightly r?#gfx-reviewers

Comment 5

[Ashley Hale [:ahale]]

I (and reviewers) missed one pref that should have a conditional value, so made another patch for that. I can move it to another bug if necessary.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/94c9f2a64f9c
https://hg.mozilla.org/integration/autoland/rev/5924af1d12ba
fix layout.css.video-dynamic-range.allows-high pref initial value on Windows for early-beta/nightly r=gfx-reviewers,jimb

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1ce82d084f8f
https://hg.mozilla.org/mozilla-central/rev/5924af1d12ba

Comment 8

[Donal Meehan [:dmeehan]]

:ahale, could you consider nominating this for a release note? (Process info)
We could include it in the nightly only release notes.

Comment 9

[Ashley Hale [:ahale]]

Release Note Request (optional, but appreciated)
[Why is this notable]: HDR video has been the most requested feature on MozillaConnect, users will be eager to experiment with this and confirm if it works properly.
[Affects Firefox for Android]: No
[Suggested wording]: HDR video on Windows is now supported in Firefox Nightly 148, this is considered experimental as we gather feedback before enabling in regular releases. This feature works best if HDR mode is enabled in Display Settings (may require a page refresh), otherwise the display driver is likely to apply a tonemapping effect for non-HDR viewing. Some streaming sites may still not offer HDR video in Firefox.
[Links (documentation, blog post, etc)]: A blog post is being drafted, URL not available yet. It will be at https://mozillagfx.wordpress.com/ when it is ready, it will be more detailed than this relnote.

Comment 10

[Donal Meehan [:dmeehan]]

Added to the Fx148 nightly release notes, please allow 30 minutes for the site to update.
The nightly-only note will be removed after three cycles or when it is enabled by default, whichever comes earlier.

We can update the release note to add a URL for the blog post once it's ready.