1977762 - Replace the google.protobuf.Duration with a custom Duration message in safebrowsing_v5.proto

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement)

Description

[Tim Huang[:timhuang]]

Potentially, we can reduce the installer size on Windows by replacing the google.protobuf.Duration in safebrowsing_v5.proto because we can reduce the number of protobuf files that need to be compiled.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1977762 - Replace the google.protobuf.Duration with a local Duration message in safebrowsing_v5.proto. r?dimi!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a34518f8711
https://hg.mozilla.org/integration/autoland/rev/0b92385777d9
Replace the google.protobuf.Duration with a local Duration message in safebrowsing_v5.proto. r=dimi

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0b92385777d9

Comment 4

[Mayank Bansal]

this reduced the size by 313KB on windows.

Comment 5

[Florin Bilt]

(In reply to Serban Stanca [:SerbanS] from comment #3)

https://hg.mozilla.org/mozilla-central/rev/0b92385777d9

Perfherder has detected a build_metrics performance change from push 0b92385777d97c0af098947f30927be7a15e66e6.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.29%	installer size	windows2012-64-shippable	nightly	125,192,692.88 -> 124,828,300.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45986

The following documentation link provides more information about this command.