1977765 - [toolbar redesign] Microsurvey is not anchored to the navbar when address bar is at top

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

Steps to reproduce

1. ensure the address bar is set to be shown at the top
2. enable the toolbar redesign and the microsurvey feature from secret settings
3. while in a browser tab tap to print
4. close the print UX

Expected behavior

A microsurvey banner is shown on top (y axis) of the navigation bar

Actual behavior

The microsurvey banner is shown above (z axis) of the navigation bar covering it

Any additional information?

A similar issue does not exist if the address bar is set to be shown at the bottom.

Comment 1

[Roger Yang [:royang]]

Looks like snackbars have the same problem.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Layout inspector showing two composables with the same id in the layout

(In reply to Roger Yang [:royang] from comment #1)

Looks like snackbars have the same problem.

For me the snackbar is correctly anchored to the navbar when the address bar is shown at the top of the screen.
But I think there might be a race and I'm just lucky while you aren't 😛
Seems like both the addressbar and the navbar are added to the layout with the same id (which somehow works) and maybe in your case the SnackbarBehavior tries to anchor the snackbar to the top addressbar? I would be curious to see how it looks for you.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1977765 - Show the microsurvey on top of the navbar r=#android-reviewers

For now we're following the same flow as with the bottom toolbar.
A bigger refactoring to come later.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1977765 - Reuse existing navigation bar view id to anchor other popups r=#android-reviewers

From the previous navigation bar implementation we had the toolbar_navbar_container
view id still lingering in the application but unused.
Since we saw that when using the new navigation bar it would be added in the layout
with the same id as the composable toolbar we'll go with using the pre-existent
navigation bar id to distinguish between the two and ensure application popups will be
correctly anchored.

Renamed the toolbar_navbar_container to navigation_bar because with the new
implementation we don't have a container.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/39dc1d0ac847
https://hg.mozilla.org/integration/autoland/rev/5853b4e5fe04
Show the microsurvey on top of the navbar r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/95aee5ae00c4
https://hg.mozilla.org/integration/autoland/rev/35f9750e2935
Reuse existing navigation bar view id to anchor other popups r=android-reviewers,Roger

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5853b4e5fe04
https://hg.mozilla.org/mozilla-central/rev/35f9750e2935