Closed Bug 1977771 (clang-22) Opened 1 year ago Closed 3 months ago

Update builders to clang 22

Categories

(Firefox Build System :: Toolchains, task)

task

Tracking

(firefox155 wontfix, firefox156 fixed)

RESOLVED FIXED
155 Branch
Tracking Status
firefox155 --- wontfix
firefox156 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Keywords: perf-alert)

Attachments

(1 external file)

(when it's released)

It's released now. Building 140.8.0esr needs to backport the bindgen change: https://github.com/rust-lang/rust-bindgen/pull/3278 and the skcms change: https://skia-review.googlesource.com/c/skcms/+/1038217.

I've not tried nightly for now.

Blocks: rustc-1.95
Depends on: 2039467
Depends on: 2050344
Depends on: 2050734
Depends on: 2039812
Depends on: 2052112
Depends on: 2052116
Depends on: 2052441
Depends on: 2052456
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED

Backed out for causing toolchain bustages

Flags: needinfo?(mh+mozilla)
Depends on: 2060781
Flags: needinfo?(mh+mozilla)
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d77a7079309c https://hg.mozilla.org/integration/autoland/rev/651119cf9020 Revert "Bug 1977771, Bug 2039416 - Update builders to clang 22. r=firefox-build-system-reviewers,sergesanspaille" for causing toolchain failures.

Backed out for causing toolchain failures.

Flags: needinfo?(mh+mozilla)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
See Also: → 2061029

I had to revert this to get local Windows builds working. Unfortunately, I accidentally lost the output log and I don't have time to re-run the broken build right now, but it was failing due to '--target=wasm32-wasi' being deprecated. My build still seemed to be using clang 21.x even after a mach bootstrap.

Regressions: 2061070
Regressions: 2061012
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/02e25036dc44 https://hg.mozilla.org/mozilla-central/rev/a930bda5ad38 Revert "Bug 1977771 - Update builders to clang 22. r=firefox-build-system-reviewers,sergesanspaille" on dev request
Regressions: 2061041
Regressions: 2061033
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Regressions: 2061715
Regressions: 2061716
Regressions: 2062662
No longer regressions: 2061715

(In reply to Pulsebot from comment #12)

Pushed by rperta@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/02e25036dc44
https://hg.mozilla.org/mozilla-central/rev/a930bda5ad38
Revert "Bug 1977771 - Update builders to clang 22.
r=firefox-build-system-reviewers,sergesanspaille" on dev request

Perfherder has detected a talos performance change.

No action is required from the author; this comment is provided for informational purposes only.

Regression Test Platform Options Absolute values [old vs new]
5% perf_reftest_singletons svg-text-textLength-1.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 8.97 ms -> 9.42 ms
Improvement Test Platform Options Absolute values [old vs new]
6% perf_reftest_singletons svg-text-getExtentOfChar-1.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 646.65 ms -> 606.97 ms
6% perf_reftest_singletons svg-text-getExtentOfChar-1.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 647.45 ms -> 610.39 ms

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert

(In reply to Pulsebot from comment #12)

Pushed by rperta@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/02e25036dc44
https://hg.mozilla.org/mozilla-central/rev/a930bda5ad38
Revert "Bug 1977771 - Update builders to clang 22.
r=firefox-build-system-reviewers,sergesanspaille" on dev request

Perfherder has detected a build_metrics performance change from push 8011f9dd9c42d29681ba20b8d834a0d1e8537a4b.

No action is required from the author; this comment is provided for informational purposes only.

Regression Test Platform Options Absolute values [old vs new]
0.16% installer size win64-nightlyasrelease nightly nightly-as-release 136,875,951.67 -> 137,094,995.50
Improvement Test Platform Options Absolute values [old vs new]
87% sccache cache_write_errors osx-aarch64-nightlyasrelease instrumented 4,156.42 -> 549.58
76% sccache cache_write_errors windows2012-aarch64 aarch64 5,505.50 -> 1,315.75

Need Help or Information?

If you have any questions, please reach out to afinder@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

(In reply to Pulsebot from comment #9)

Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/36abd325b3cb
https://hg.mozilla.org/integration/autoland/rev/87733f2606a4
Update builders to clang 22. r=firefox-build-system-reviewers,sergesanspaille

Perfherder has detected a talos performance change from push 87733f2606a4f5cd419be4e518507b66d37c3039.

No action is required from the author; this comment is provided for informational purposes only.

Regression Test Platform Options Absolute values [old vs new]
6% perf_reftest_singletons svg-text-getExtentOfChar-1.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 606.34 ms -> 639.68 ms
Improvement Test Platform Options Absolute values [old vs new]
23% perf_reftest_singletons thai-reflow.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 35.50 ms -> 27.34 ms

Need Help or Information?

If you have any questions, please reach out to afinder@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

No longer regressions: 2061716
Status: REOPENED → RESOLVED
Closed: 3 months ago → 3 months ago
Resolution: --- → FIXED
See Also: → 1930895

Perfherder has detected a mozperftest performance change from push 0d975b238e7ec55c4ac4776afcd9318d3134cc68.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
5% browser_displayContentsBounds.js A11Y_TotalTime linux2404-64-shippable 514.93 ms -> 488.32 ms

Need Help or Information?

If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Regressions: 2065447
Regressions: 2066430
Depends on: 2066534
Depends on: 2066535
Depends on: 2066536
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: