1977784 - Strict MIME type checks breaks dynamic import of JSON modules in workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Jonatan Klemets [:jon4t4n]]

Since bug 1858078 JSON module (i.e. with {type: "json"}) loads have their own nsContentPolicyType(s), and bug 1966620 will start enforcing strict MIME type checking for JSON loads. In WorkerScriptLoader::GetContentPolicyType, we currently always return nsIContentPolicy::TYPE_INTERNAL_MODULE for dynamic imports, so JSON modules will fail to load. We want to change this to return nsIContentPolicy::TYPE_JSON, similar to what we do in the DOM script loader.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858078

Comment 2

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1977784 - Update WorkerScriptLoader::GetContentPolicyType to return TYPE_JSON for JSON modules r=#dom-worker-reviewers

Since bug 1858078, JSON modules (using {type: "json"}) have dedicated
nsIContentPolicy values, and bug 1966620 will enforce strict MIME type
checking.

Currently, WorkerScriptLoader::GetContentPolicyType always returns
nsIContentPolicy::TYPE_INTERNAL_MODULE for dynamic imports, which
causes JSON modules to fail loading when strict MIME checking is
applied.

This patch changes GetContentPolicyType to return
nsIContentPolicy::TYPE_JSON for JSON modules, matching the behavior of
the DOM script loader and fixing dynamic imports of JSON modules in
worker contexts.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1858078

Comment 4

[Tom Schuster (MoCo)]

Do you need help getting this landed?

Comment 5

[Jonatan Klemets [:jon4t4n]]

(In reply to Tom Schuster (MoCo) from comment #4)

Do you need help getting this landed?

Been OOO for a week, but now when I tried to land the stack, it looks odd in lando. The repository of https://phabricator.services.mozilla.com/D257112 is beta and not autoland for some reason. Do you know if I can just edit the revision in Phabricator and select the autoland repository?

Comment 6

[Tom Schuster (MoCo)]

I am not sure, I would just try it? You should not be able to push to beta accidentally if you are worried about that.

Comment 7

[Mathew Hodson]

It's bug 1963406. You can fix the target repository by going to "Edit Revision" and changing it back to autoland. Double check the diff that phabricator shows. It will have changed the diff back to the version that was commited and backed out on July 16. So if you have made changes since then, you will need to use moz-phab again to get your most recent local changes back into phabricator.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/802c662da903
https://hg.mozilla.org/integration/autoland/rev/7501bab1f718
Update WorkerScriptLoader::GetContentPolicyType to return TYPE_JSON for JSON modules r=dom-worker-reviewers,edenchuang

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7501bab1f718

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jon4t4n, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.