1977903 - Remove comment in the updated() function

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

There's an unneeded comment in the updated function in moz-promo.

Acceptance Criteria:

• The comment in the updated function in moz-promo is removed
• No other changes are made

Comment 1

[Balraj Dhawan]

Hi Tim, Can I work on this? Can you confirm the reviewer I should use?

Comment 2

[Tim Giles [:tgiles]]

Hey Balraj, feel free to work on this! Here's some more information to help you get started with the process!

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug. You'll need to remove the comment in the updated function in moz-promo
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me by using the "Request information from" checkbox and setting the dropdown select to "mentor". Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with ./mach build and test your change with ./mach test toolkit/content/tests/widgets/test_moz_promo.html --headless. Also check your changes for adherence to our style guidelines by using ./mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 3

[Balraj Dhawan]

Attachment: Bug 1977903 - Remove comment from updated() function. r=tgiles

Comment 4

[Balraj Dhawan]

Hi Tim,

I worked on it and submitted a patch for it as well.

Thanks for the detailed steps and guidance — I really appreciate it!

Best,
Balraj

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dee954f1b199
https://hg.mozilla.org/integration/autoland/rev/a3fbfb632f43
Remove comment from updated() function. r=tgiles,reusable-components-reviewers

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a3fbfb632f43