1977915 - Avoid creating 2 homepage private tabs when switching to private mode with Homepage as a New Tab enabled

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

STR:

1. Enable Homepage as a New Tab via Secret Settings.
2. Have no private tabs.
3. Open the tabs tray and open a private tab.
4. Observe that 2 private homepage tabs are opened.

Expected:

• Only 1 private homepage tab should be opened.

We need to remove the call to HomeActivity#addPrivateHomepageTabIfNecessary. This was originally added to mitigate not having an opened private tab when the user clicked on the Private Browsing Mode toggle button to switch to private mode from the homepage, and then navigating to a site only to browse using the selected tab which is still in normal browsing mode. See Bug 1914852 for the use case.

Now that the PBM toggle button is removed from the homepage and private tabs are opened via the tabs tray, we do not need to mitigate this use case.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1977915 - Revert "Bug 1914852 - Ensure there's always a single private homepage tab when switching to private mode when Homepage as a New Tab is enabled"

This reverts commit 94443f05d4285664ba691068e811ac0d7afc63ba.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f9030195e5c4
https://hg.mozilla.org/integration/autoland/rev/814be6d7e78c
Revert "Bug 1914852 - Ensure there's always a single private homepage tab when switching to private mode when Homepage as a New Tab is enabled" r=android-reviewers,devota

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/814be6d7e78c