1977922 - [HDR] DMABufSurface memleaks during HDR playback

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

DMABufSurfaces are leaking during playback as we don't release external buffers so they can't be recycled.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1977922 [Wayland] Delete BufferTransaction on buffer detach for external buffers r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/436d79edbe9f
https://hg.mozilla.org/integration/autoland/rev/6e9a94a46671
[Wayland] Delete BufferTransaction on buffer detach for external buffers r=emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9501511 [details]
Bug 1977922 [Wayland] Delete BufferTransaction on buffer detach for external buffers r?emilio

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes memleaks on HDR playback and it's needed for Bug 1978207 - fix memleaks for SW-WR SHM buffers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Releases unused dmabuf buffers.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6e9a94a46671

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9501511 [details]
Bug 1977922 [Wayland] Delete BufferTransaction on buffer detach for external buffers r?emilio

Approved for 142.0b3

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/938871a6f98b
https://hg.mozilla.org/releases/mozilla-beta/rev/f33b52765af8