1977997 - Remove `network.proxy.testing_localhost_is_secure_when_hijacked` to simplify testing

Status: ASSIGNED

(Core :: Networking, task, P2)

Description

[Frederik Braun [:freddy] (OOO until August 18th)]

Common testing tool cypress can not perform testing on APIs that require a localhost because we require the pref network.proxy.testing_localhost_is_secure_when_hijacked to be true, even though we already have a separate pref to allow hijacking localhost in the first place.

Since the latter is such a very rare thing to set, we should just fold them together.

Comment 1

[Frederik Braun [:freddy] (OOO until August 18th)]

Attachment: Bug 1977997 - remove pref network_proxy_testing_localhost_is_secure_when_hijacked r?kershaw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83542923f965
https://hg.mozilla.org/integration/autoland/rev/a4763f31fcc8
remove pref network_proxy_testing_localhost_is_secure_when_hijacked r=kershaw,necko-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61abc5ae450e
https://hg.mozilla.org/integration/autoland/rev/cea08b0fc91a
Revert "Bug 1977997 - remove pref network_proxy_testing_localhost_is_secure_when_hijacked r=kershaw,necko-reviewers" for causing netwerk related failures

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing xpcshell failures

Backout link

Push with failures

Failure log

Comment 5

[Frederik Braun [:freddy] (OOO until August 18th)]

Attachment: Bug 1977997 - default pref network_proxy_testing_localhost_is_secure_when_hijacked to true r=kershaw

Comment 6

[Frederik Braun [:freddy] (OOO until August 18th)]

Looks like this breaks too much tests. Let's default it to true before we remove it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/715d24501242
https://hg.mozilla.org/integration/autoland/rev/fa2581954aba
default pref network_proxy_testing_localhost_is_secure_when_hijacked to true r=kershaw,necko-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8628d0d99841
https://hg.mozilla.org/integration/autoland/rev/a81b1baa12b9
Revert "Bug 1977997 - default pref network_proxy_testing_localhost_is_secure_when_hijacked to true r=kershaw,necko-reviewers" for causing xpcshell failures on test_dns_override_for_localhost.js

Comment 9

[Cristina Horotan [:chorotan]]

Backed out for causing xpcshell failures on test_dns_override_for_localhost.js

Backout link

Push with failures

Failure log

Comment 10

[Frederik Braun [:freddy] (OOO until August 18th)]

Huh, I can't reproduce the failure locally. It just works here flawlessly. Any idea why this shouldn't break on macOS, Kershaw?

Comment 11

[Kershaw Chang [:kershaw]]

(In reply to Frederik Braun [:freddy] from comment #10)

Huh, I can't reproduce the failure locally. It just works here flawlessly. Any idea why this shouldn't break on macOS, Kershaw?

Ah, that's because that pref (network.proxy.testing_localhost_is_secure_when_hijacked) is not updated to socket process.
Adding the pref in this list should work.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47dedd5d27d2
https://hg.mozilla.org/integration/autoland/rev/4c5aafeb4340
default pref network_proxy_testing_localhost_is_secure_when_hijacked to true r=kershaw,necko-reviewers

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a663649b6874
https://hg.mozilla.org/integration/autoland/rev/e5b608577ef5
Revert "Bug 1977997 - default pref network_proxy_testing_localhost_is_secure_when_hijacked to true r=kershaw,necko-reviewers" for failing xpcshell's dom/base/test/unit/test_error_codes.js

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing xpcshell's dom/base/test/unit/test_error_codes.js:
https://hg.mozilla.org/integration/autoland/rev/e5b608577ef55642b78df3ad37990f02cede080a

• Push with failures
• Failure log

[task 2025-07-25T11:52:44.087+00:00] 11:52:44  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/unit/test_error_codes.js | xpcshell return code: 0
[task 2025-07-25T11:52:44.089+00:00] 11:52:44     INFO -  TEST-INFO took 4324ms
[task 2025-07-25T11:52:44.089+00:00] 11:52:44     INFO -  >>>>>>>
[task 2025-07-25T11:52:44.089+00:00] 11:52:44     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2025-07-25T11:52:44.090+00:00] 11:52:44     INFO -  (xpcshell/head.js) | test pending (2)
[task 2025-07-25T11:52:44.090+00:00] 11:52:44     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2025-07-25T11:52:44.091+00:00] 11:52:44     INFO -  running event loop
[task 2025-07-25T11:52:44.091+00:00] 11:52:44     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2025-07-25T11:52:44.091+00:00] 11:52:44     INFO -  PID 6012 | Testing error returned by async XHR when the network is offline
[task 2025-07-25T11:52:44.092+00:00] 11:52:44  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/unit/test_error_codes.js | doAsyncRequest_onError - [doAsyncRequest_onError : 19] 2152398861 == 2152398864
[task 2025-07-25T11:52:44.092+00:00] 11:52:44     INFO -  D:/task_175344212125030/build/tests/xpcshell/tests/dom/base/test/unit/test_error_codes.js:doAsyncRequest_onError:19
[task 2025-07-25T11:52:44.092+00:00] 11:52:44     INFO -  D:\task_175344212125030\build\tests\xpcshell\head.js:_do_main:245
[task 2025-07-25T11:52:44.092+00:00] 11:52:44     INFO -  D:\task_175344212125030\build\tests\xpcshell\head.js:_execute_test:607
[task 2025-07-25T11:52:44.092+00:00] 11:52:44     INFO -  -e:null:1
[task 2025-07-25T11:52:44.092+00:00] 11:52:44     INFO -  exiting test
[task 2025-07-25T11:52:44.093+00:00] 11:52:44     INFO -  PID 6012 | JavaScript error: D:\\task_175344212125030\\build\\tests\\xpcshell\\head.js, line 880: NS_ERROR_ABORT:
[task 2025-07-25T11:52:44.093+00:00] 11:52:44  WARNING -  TEST-UNEXPECTED-FAIL | dom/base/test/unit/test_error_codes.js | doAsyncRequest_onLoad - [doAsyncRequest_onLoad : 14] Should have received an error - false == true
[task 2025-07-25T11:52:44.094+00:00] 11:52:44     INFO -  D:/task_175344212125030/build/tests/xpcshell/tests/dom/base/test/unit/test_error_codes.js:doAsyncRequest_onLoad:14
[task 2025-07-25T11:52:44.094+00:00] 11:52:44     INFO -  D:\task_175344212125030\build\tests\xpcshell\head.js:_do_main:245
[task 2025-07-25T11:52:44.094+00:00] 11:52:44     INFO -  D:\task_175344212125030\build\tests\xpcshell\head.js:_execute_test:607