1978052 - trr_request_count_per_conn incorrectly reports http protocol version of 1.1

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P3)

Description

[Andrew Creskey [:acreskey]]

In this query we see a very high % of Fenix TRR connections being made over HTTP/1.1.

However, this conflicts with the reporting of other probes -- see https://bugzilla.mozilla.org/show_bug.cgi?id=1976996#c4

I believe there's a bug in how we mark trr_request_count_per_conn as "h1"
https://searchfox.org/mozilla-central/rev/ac81a39dfe0663eb40a34c7c36d89e34be29cb20/netwerk/protocol/http/nsHttpConnection.cpp#68-84
We test if (!mEverUsedSpdy) and I suspect we end up counting http/3 connections.

Comment 1

[Kershaw Chang [:kershaw]]

I believe there's a bug in how we mark trr_request_count_per_conn as "h1"
https://searchfox.org/mozilla-central/rev/ac81a39dfe0663eb40a34c7c36d89e34be29cb20/netwerk/protocol/http/nsHttpConnection.cpp#68-84
We test if (!mEverUsedSpdy) and I suspect we end up counting http/3 connections.

hmm... but nsHttpConnection should only be used for TCP connections.
Maybe the reason is that we increase mHttp1xTransactionCount without checking the status or those h1 connections were from some user specified trr server. Anyway, I think it'd be good to improve this metric. I'll prepare a patch.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1978052 - Improve trr_request_count_per_conn by including the provider key, r=acreskey

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aada08c6ebc5
https://hg.mozilla.org/integration/autoland/rev/f609ea3a3c22
Improve trr_request_count_per_conn by including the provider key, r=acreskey

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f609ea3a3c22