Closed Bug 1978197 Opened 1 year ago Closed 1 year ago

[webgpu] Demo at https://codepen.io/mootytootyfrooty/pen/ByNxqKB doe not work in Nightly

Categories

(Core :: Graphics: WebGPU, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mayankleoboy1, Assigned: ErichDonGubler)

References

()

Details

Attachments

(1 file)

Go to https://codepen.io/mootytootyfrooty/pen/ByNxqKB

Error in console:
injected firefox 2 content.js:239:17
11:28:44.110 Uncaptured WebGPU error: Internal error: DXC compile error: hlsl.hlsl:1519:19: error: expected unqualified-id
float 2_ = (unnamed_9 + swirlAmt_1);
^
hlsl.hlsl:1520:30: error: invalid suffix '' on integer constant
vx = (r_8 * cos(2
));
^
hlsl.hlsl:1521:30: error: invalid suffix '' on integer constant
vy = (r_8 * sin(2
));
^
hlsl.hlsl:1740:19: error: expected unqualified-id
float 0_ = atan2(my_2, mx_2);
^
hlsl.hlsl:1743:52: error: invalid suffix '' on integer constant
float warp = exp((beta_2 * cos((2.0 * 0
))));
^
hlsl.hlsl:1744:39: error: invalid suffix '' on integer constant
nx = ((r_9 * warp) * cos(0
));
^
hlsl.hlsl:1745:39: error: invalid suffix '' on integer constant
ny = ((r_9 * warp) * sin(0
));
^
hlsl.hlsl:1793:19: error: expected unqualified-id
float 0_1 = atan2(my_3, mx_3);
^
hlsl.hlsl:1796:54: error: invalid suffix '_1' on integer constant
float warp_1 = exp((beta_3 * cos((2.0 * 0_1))));
^
hlsl.hlsl:1797:47: error: invalid suffix '_1' on integer constant
float x = ((r_10 * warp_1) * cos(0_1));
^
hlsl.hlsl:1798:47: error: invalid suffix '_1' on integer constant
float y = ((r_10 * warp_1) * sin(0_1));
^

11:28:44.121 Uncaptured WebGPU error: ComputePipeline with '' label is invalid
11:28:44.121 Uncaptured WebGPU error: In a pass parameter, caused by: Encoder is invalid

Attached file about:support —

:jimb, can you comment to this bug?

Severity: -- → S3
Flags: needinfo?(jimb)
Flags: needinfo?(jimb)
Priority: -- → P3

Ah, this is because this shader is using non-ASCII identifiers characters for some of its variables, and WebGPU's shader compiler wasn't handling that correctly. I can confirm that wgpu#7995 fixes this locally; tracking it as a dependency.

Assignee: nobody → egubler
Status: NEW → ASSIGNED
Depends on: 1992842
No longer depends on: webgpu-update-wgpu

WFM on my M1 MacBook Pro. Mayank, can you confirm that this is fixed now?

Flags: needinfo?(mayankleoboy1)

this is fixed.

Flags: needinfo?(mayankleoboy1)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: