1978320 - Missing partner code in metrics.search_count metric

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect)

Description

[Delia Pop (Android QA)]

Steps to reproduce

1. Launch any custom debug builds hardcoded aura-001, dt-002, dt-003 distribution IDs.
2. Turn off the “Use remote settings production server" option in Secret Settings.
3. Restart the app.
4. Set the region to US or a region outside US (e.g. FR, DE, JP) using the debug drawer.
5. Perform a search using the Google search engine.
6. Sent the metrics ping type using the Glean Debug Tools and check the metrics in Glean.

Expected behavior

metrics.search_count should be recorded with a key of google-b-1-ar.<source> for the US, or google-b-ar.<source> for the rest of the world:
e.g. for a region outside US:
"metrics.search_count": {
"google-b-ar.action": 1

Actual behavior

The partner code is missing.
e.g. for a region outside US:
"metrics.search_count": {
"google.action": 6

Device information

Firefox version: Custom debug builds, hardcoded aura-001, dt-002, dt-003 distribution IDs provided on slack
Android device model: Google Pixel 8 Pro (Android 15)

Additional information

Tested on multiple regions set using the Debug Drawer/devices settings and VPN.
Tested with “Use remote settings production server" option from Secret Settings enabled and disabled.

Comment 1

[Mark Banner (:standard8)]

This appears to have been caused by the search consolidation work, and is reflected in the telemetry we're seeing.

The key used for telemetry in this case should be the search engine identifier plus the suffix if there is one (something equivalent to this).

Sarah, would you be able to take a look or find someone who could look please?

Comment 2

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1978320 - Add partner code in telemetry when searching

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1969324

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c18425025e1
https://hg.mozilla.org/integration/autoland/rev/79a477f38874
Add partner code in telemetry when searching r=android-reviewers,skhan

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/79a477f38874

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:RJ, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1978320 - Add partner code in telemetry when searching

Original Revision: https://phabricator.services.mozilla.com/D258075

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Wrong telemetry would be recorded when searching
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check if the correct telemetry is recorded when searching
• Risk associated with taking this patch: Very low
• Explanation of risk level: Modifies existing telemetry
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a430807fece1
https://hg.mozilla.org/releases/mozilla-beta/rev/1cfaa516a6d8

Comment 10

[Delia Pop (Android QA)]

Verified as fixed on latest Nightly 143.0a1 from 07/25 with Motorola Moto G30 (Android 12):

Nightly "metrics.search_count": {
"google-b-1-m.action": 1
},

Comment 11

[Delia Pop (Android QA)]

Verified as fixed in Beta 142.0b3 with Google Pixel 8 Pro (Android 15):

Beta
"metrics.search_count": {
"google-b-1-m.action": 1

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Do we need to uplift this to Release as well for 141.0.2?

Comment 13

[Rhodwell Malicdem [:RJ]]

Do we need to uplift this to Release as well for 141.0.2?

Yes

Comment 14

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1978320 - Add partner code in telemetry when searching

Original Revision: https://phabricator.services.mozilla.com/D258075

Comment 15

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Wrong telemetry would be recorded when searching
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check if the correct telemetry is recorded when searching
• Risk associated with taking this patch: Very low
• Explanation of risk level: Modifies existing telemetry
• String changes made/needed: No
• Is Android affected?: no

Comment 16

[Pascal Chevrel:pascalc]

The patch failed to land on the release branch, could you rebase and update your uplift request? Thanks

Comment 17

[Rhodwell Malicdem [:RJ]]

Uplift request rebased!

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c64e367fb370
https://hg.mozilla.org/releases/mozilla-release/rev/843ec7adf978

Comment 19

[Delia Pop (Android QA)]

Verified as fixed in dot release 141.0.2 with Google Pixel 8 Pro (Android 15):

"metrics.search_count": {
"google-b-1-m.action": 1